fixes #2620

Author: retailcoder

Rubberduck.Parsing/Symbols/BoundExpressionVisitor.cs

@@ -1,5 +1,6 @@
 using Rubberduck.Parsing.Annotations;
 using Rubberduck.Parsing.Binding;
+using Rubberduck.Parsing.Grammar;
 using Rubberduck.VBEditor;
 
 namespace Rubberduck.Parsing.Symbols
@@ -47,6 +48,12 @@ private void Visit(
             bool isAssignmentTarget,
             bool hasExplicitLetStatement)
         {
+            if (isAssignmentTarget && expression.Context.Parent is VBAParser.IndexExprContext)
+            {
+                // 'SomeDictionary' is not the assignment target in 'SomeDictionary("key") = 42'
+                isAssignmentTarget = false;
+            }
+
             var callSiteContext = expression.Context;
             var identifier = expression.Context.GetText();
             var callee = expression.ReferencedDeclaration;

RubberduckTests/Inspections/ObjectVariableNotSetInpsectionTests.cs

@@ -16,6 +16,34 @@ namespace RubberduckTests.Inspections
     [TestClass]
     public class ObjectVariableNotSetInpsectionTests
     {
+        [TestMethod]
+        [TestCategory("Inspections")]
+        public void ObjectVariableNotSet_GivenIndexerObjectAccess_ReturnsNoResult()
+        {
+            const string inputCode = @"
+Private Sub DoSomething()
+    Dim target As Object
+    Set target = CreateObject(""Scripting.Dictionary"")
+    target(""foo"") = 42
+End Sub
+";
+            //Arrange
+            var builder = new MockVbeBuilder();
+            IVBComponent component;
+            var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
+            var mockHost = new Mock<IHostApplication>();
+            mockHost.SetupAllProperties();
+            var parser = MockParser.Create(vbe.Object, new RubberduckParserState(vbe.Object));
+
+            parser.Parse(new CancellationTokenSource());
+            if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
+
+            var inspection = new ObjectVariableNotSetInspection(parser.State);
+            var inspectionResults = inspection.GetInspectionResults();
+
+            Assert.AreEqual(0, inspectionResults.Count());
+        }
+
         [TestMethod]
         [TestCategory("Inspections")]
         public void ObjectVariableNotSet_GivenStringVariable_ReturnsNoResult()