Merge pull request #910 from retailcoder/next

Inspections Meta

Author: retailcoder

RetailCoder.VBE/App.cs

@@ -138,7 +138,7 @@ private async void hooks_MessageReceived(object sender, HookEventArgs e)
 
         private void _stateBar_Refresh(object sender, EventArgs e)
         {
-            _parser.State.RequestParse();
+            _parser.State.OnParseRequested();
         }
 
         private void Parser_StateChanged(object sender, EventArgs e)
@@ -153,10 +153,11 @@ public void Startup()
             _appMenus.Initialize();
             _appMenus.Localize();
 
+            // delay to allow the VBE to properly load. HostApplication is null until then.
             Task.Delay(1000).ContinueWith(t =>
             {
                 _parser.State.AddBuiltInDeclarations(_vbe.HostApplication());
-                _parser.State.RequestParse();
+                _parser.State.OnParseRequested();
             });
 
             //_hooks.AddHook(new LowLevelKeyboardHook(_vbe));

RetailCoder.VBE/Extension.cs

@@ -1,6 +1,5 @@
 using System;
 using System.ComponentModel;
-using System.Diagnostics;
 using System.Runtime.InteropServices;
 using System.Windows.Forms;
 using Extensibility;
@@ -40,10 +39,6 @@ public void OnConnection(object Application, ext_ConnectMode ConnectMode, object
                 _kernel.Load(new RubberduckModule(_kernel, (VBE)Application, (AddIn)AddInInst));
                 _kernel.Load(new UI.SourceControl.SourceControlBindings());
                 _kernel.Load(new CommandBarsModule(_kernel));
-                
-                Debug.Print("in OnConnection, ready.");
-                var app = _kernel.Get<App>();
-                app.Startup();
             }
             catch (Exception exception)
             {
@@ -53,7 +48,8 @@ public void OnConnection(object Application, ext_ConnectMode ConnectMode, object
 
         public void OnStartupComplete(ref Array custom)
         {
-
+            var app = _kernel.Get<App>();
+            app.Startup();
         }
 
         public void OnDisconnection(ext_DisconnectMode RemoveMode, ref Array custom)

RetailCoder.VBE/Inspections/AssignedByValParameterInspection.cs

@@ -16,6 +16,7 @@ public AssignedByValParameterInspection()
         }
 
         public string Name { get { return "AssignedByValParameterInspection"; } }
+        public string Meta { get { return InspectionsUI.ResourceManager.GetString(Name + "Meta"); } }
         public string Description { get { return RubberduckUI.ByValParameterIsAssigned_; } }
         public CodeInspectionType InspectionType { get { return CodeInspectionType.CodeQualityIssues; } }
         public CodeInspectionSeverity Severity { get; set; }

RetailCoder.VBE/Inspections/ConstantNotUsedInspection.cs

@@ -14,6 +14,7 @@ public ConstantNotUsedInspection()
         }
 
         public string Name { get { return "ConstantNotUsedInspection"; } }
+        public string Meta { get { return InspectionsUI.ResourceManager.GetString(Name + "Meta"); } }
         public string Description { get { return RubberduckUI.ConstantNotUsed_; } }
         public CodeInspectionType InspectionType { get { return CodeInspectionType.CodeQualityIssues; } }
         public CodeInspectionSeverity Severity { get; set; }

RetailCoder.VBE/Inspections/DefaultProjectNameInspection.cs

@@ -18,6 +18,7 @@ public DefaultProjectNameInspection()
         }
 
         public string Name { get { return "DefaultProjectNameInspection"; } }
+        public string Meta { get { return InspectionsUI.ResourceManager.GetString(Name + "Meta"); } }
         public string Description { get { return RubberduckUI.GenericProjectName_; } }
         public CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
         public CodeInspectionSeverity Severity { get; set; }

RetailCoder.VBE/Inspections/EmptyStringLiteralInspection.cs

@@ -14,6 +14,7 @@ public EmptyStringLiteralInspection()
         }
 
         public string Name { get { return "EmptyStringLiteralInspection"; } }
+        public string Meta { get { return InspectionsUI.ResourceManager.GetString(Name + "Meta"); } }
         public string Description { get { return InspectionsUI.EmptyStringLiteralInspection; } }
         public CodeInspectionType InspectionType { get { return CodeInspectionType.LanguageOpportunities; } }
         public CodeInspectionSeverity Severity { get; set; }

RetailCoder.VBE/Inspections/IInspection.cs

@@ -13,5 +13,10 @@ public interface IInspection : IInspectionModel
         /// </summary>
         /// <returns>Returns inspection results, if any.</returns>
         IEnumerable<CodeInspectionResultBase> GetInspectionResults(RubberduckParserState state);
+
+        /// <summary>
+        /// Gets a string that contains additional/meta information about an inspection.
+        /// </summary>
+        string Meta { get; }
     }
 }

RetailCoder.VBE/Inspections/ImplicitActiveSheetReferenceInspection.cs

@@ -22,6 +22,7 @@ public ImplicitActiveSheetReferenceInspection(VBE vbe)
         }
 
         public string Name { get { return "ImplicitActiveSheetReferenceInspection"; } }
+        public string Meta { get { return InspectionsUI.ResourceManager.GetString(Name + "Meta"); } }
         public string Description { get { return RubberduckUI.ImplicitActiveSheetReference_; } }
         public CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
         public CodeInspectionSeverity Severity { get; set; }

RetailCoder.VBE/Inspections/ImplicitActiveWorkbookReferenceInspection.cs

@@ -20,6 +20,7 @@ public ImplicitActiveWorkbookReferenceInspection(VBE vbe)
         }
 
         public string Name { get { return "ImplicitActiveWorkbookReferenceInspection"; } }
+        public string Meta { get { return InspectionsUI.ResourceManager.GetString(Name + "Meta"); } }
         public string Description { get { return RubberduckUI.ImplicitActiveWorkbookReference_; } }
         public CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
         public CodeInspectionSeverity Severity { get; set; }

RetailCoder.VBE/Inspections/ImplicitByRefParameterInspection.cs

@@ -17,6 +17,7 @@ public ImplicitByRefParameterInspection()
         }
 
         public string Name { get { return "ImplicitByRefParameterInspection"; } }
+        public string Meta { get { return InspectionsUI.ResourceManager.GetString(Name + "Meta"); } }
         public string Description { get { return RubberduckUI.ImplicitByRef_; } }
         public CodeInspectionType InspectionType { get { return CodeInspectionType.CodeQualityIssues; } }
         public CodeInspectionSeverity Severity { get; set; }