Fixed stupid bug, enabled selective resolving of references.

Author: MDoerner

Rubberduck.Parsing/Symbols/DeclarationFinder.cs

@@ -44,7 +44,6 @@ public class DeclarationFinder
         private readonly ConcurrentDictionary<QualifiedModuleName, ConcurrentBag<Declaration>> _declarations;
         private readonly ConcurrentDictionary<QualifiedMemberName, ConcurrentBag<Declaration>> _newUndeclared;
         private readonly ConcurrentBag<UnboundMemberDeclaration> _newUnresolved;
-        private readonly Dictionary<QualifiedMemberName, List<Declaration>> _undeclared;
         private readonly List<UnboundMemberDeclaration> _unresolved;
         private readonly ConcurrentDictionary<QualifiedModuleName, ConcurrentBag<IAnnotation>> _annotations;
         private readonly ConcurrentDictionary<Declaration, ConcurrentBag<Declaration>> _parametersByParent;
@@ -93,7 +92,6 @@ public DeclarationFinder(IReadOnlyList<Declaration> declarations, IEnumerable<IA
                     ), true);
 
             _newUndeclared = new ConcurrentDictionary<QualifiedMemberName, ConcurrentBag<Declaration>>(new Dictionary<QualifiedMemberName, ConcurrentBag<Declaration>>());
-            _undeclared = declarations.Where(declaration => declaration.IsUndeclared).GroupBy(item => item.QualifiedName).ToDictionary(group => group.Key, group => group.ToList());
             _newUnresolved = new ConcurrentBag<UnboundMemberDeclaration>(new List<UnboundMemberDeclaration>());
             _unresolved = unresolvedMemberDeclarations.ToList();
 
@@ -144,11 +142,6 @@ public IEnumerable<Declaration> FreshUndeclared
             get { return _newUndeclared.AllValues(); }
         }
 
-        public IEnumerable<Declaration> Undeclared
-        {
-            get { return _undeclared.SelectMany(item => item.Value).ToList(); }
-        }
-
         public IEnumerable<Declaration> Members(Declaration module)
         {
             return Members(module.QualifiedName.QualifiedModuleName);

Rubberduck.Parsing/VBA/ParseCoordinator.cs

@@ -239,7 +239,6 @@ private void ExecuteCommonParseActivities(List<IVBComponent> toParse, Cancellati
                     throw new OperationCanceledException(token);
                 }
 
-            toResolveReferences = State.ParseTrees.Select(kvp => kvp.Key).ToHashSet();
             ResolveAllReferences(toResolveReferences, token);
 
                 if (token.IsCancellationRequested || State.Status >= ParserState.Error)
@@ -271,7 +270,7 @@ private void SetModuleStates(List<IVBComponent> components, ParserState parserSt
 
         private ICollection<QualifiedModuleName> ModulesForWhichToResolveReferences(List<IVBComponent> toParse)
         {
-            var toResolveReferences = new HashSet<QualifiedModuleName>();
+            var toResolveReferences = toParse.Select(component => new QualifiedModuleName(component)).ToHashSet();
             foreach (var qmn in toParse.Select(component => new QualifiedModuleName(component)))
             { 
                 toResolveReferences.UnionWith(State.ModulesReferencing(qmn));
@@ -283,7 +282,6 @@ private void PerformPreParseCleanup(List<IVBComponent> toParse, ICollection<Qual
         {
             ClearModuleToModuleReferences(toParse);
             State.RemoveAllReferencesBy(toResolveReferences);
-            State.ClearAllReferences(); //This has to stay here until the selective resolving actually works.
             _projectDeclarations.Clear();
         }