Skip to content

Commit b630e1d

Browse files
committed
Display type in UI for extract interface
1 parent 0339fd6 commit b630e1d

File tree

2 files changed

+16
-26
lines changed

2 files changed

+16
-26
lines changed

RetailCoder.VBE/Refactorings/ExtractInterface/ExtractInterfaceRefactoring.cs

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -79,19 +79,14 @@ private string GetInterfaceMember(InterfaceMember member)
7979
case "Function":
8080
return FunctionStmt(member);
8181

82-
case "Property":
83-
switch (member.PropertyType)
84-
{
85-
case "Get":
86-
return PropertyGetStmt(member);
87-
88-
case "Let":
89-
return PropertyLetStmt(member);
90-
91-
case "Set":
92-
return PropertySetStmt(member);
93-
}
94-
break;
82+
case "Property Get":
83+
return PropertyGetStmt(member);
84+
85+
case "Property Let":
86+
return PropertyLetStmt(member);
87+
88+
case "Property Set":
89+
return PropertySetStmt(member);
9590
}
9691

9792
return string.Empty;

RetailCoder.VBE/Refactorings/ExtractInterface/InterfaceMember.cs

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,13 @@ public class InterfaceMember
2525
public string Type { get; set; }
2626

2727
public string MemberType { get; set; }
28-
public string PropertyType { get; set; }
2928

3029
public bool IsSelected { get; set; }
3130
public string MemberSignature
3231
{
3332
get
3433
{
35-
var signature = Member.IdentifierName + "(" +
34+
var signature = MemberType + " " + Member.IdentifierName + "(" +
3635
string.Join(", ", MemberParams.Select(m => m.ParamType)) + ")";
3736

3837
return Type == null ? signature : signature + " As " + Type;
@@ -43,7 +42,7 @@ public string FullMemberSignature
4342
{
4443
get
4544
{
46-
var signature = Member.IdentifierName + "(" +
45+
var signature = MemberType + " " + Member.IdentifierName + "(" +
4746
string.Join(", ", MemberParams) + ")";
4847

4948
return Type == null ? signature : signature + " As " + Type;
@@ -69,12 +68,11 @@ public InterfaceMember(Declaration member, IEnumerable<Declaration> declarations
6968
})
7069
.ToList();
7170

72-
if (PropertyType == "Get")
71+
if (MemberType == "Property Get")
7372
{
7473
MemberParams = MemberParams.Take(MemberParams.Count() - 1);
7574
}
7675

77-
7876
IsSelected = false;
7977
}
8078

@@ -97,29 +95,26 @@ private void GetMethodType()
9795
var propertyGetStmtContext = context as VBAParser.PropertyGetStmtContext;
9896
if (propertyGetStmtContext != null)
9997
{
100-
MemberType = Tokens.Property;
101-
PropertyType = Tokens.Get;
98+
MemberType = Tokens.Property + " " + Tokens.Get;
10299
}
103100

104101
var propertyLetStmtContext = context as VBAParser.PropertyLetStmtContext;
105102
if (propertyLetStmtContext != null)
106103
{
107-
MemberType = Tokens.Property;
108-
PropertyType = Tokens.Let;
104+
MemberType = Tokens.Property + " " + Tokens.Let;
109105
}
110106

111107
var propertySetStmtContext = context as VBAParser.PropertySetStmtContext;
112108
if (propertySetStmtContext != null)
113109
{
114-
MemberType = Tokens.Property;
115-
PropertyType = Tokens.Set;
110+
MemberType = Tokens.Property + " " + Tokens.Set;
116111
}
117112
}
118113

119114
public override string ToString()
120115
{
121-
return "Public " + MemberType + " " + PropertyType + " " + FullMemberSignature + Environment.NewLine + "End " + MemberType +
122-
Environment.NewLine;
116+
return "Public " + FullMemberSignature + Environment.NewLine +
117+
"End " + MemberType.Split(' ').First() + Environment.NewLine;
123118
}
124119
}
125120
}

0 commit comments

Comments
 (0)