Merge pull request #1024 from Hosch250/BugBlipper

Encapsulate Public Field Inspection Tests

Author: Hosch250

RubberduckTests/Inspections/EmptyStringLiteralInspectionTests.cs

@@ -14,7 +14,7 @@ namespace RubberduckTests.Inspections
     public class EmptyStringLiteralInspectionTests
     {
         [TestMethod]
-        public void AssignedByValParameter_ReturnsResult_PassToProcedure()
+        public void EmptyStringLiteral_ReturnsResult_PassToProcedure()
         {
             const string inputCode =
 @"Public Sub Bar()
@@ -41,7 +41,7 @@ Public Sub Foo(ByRef arg1 As String)
         }
 
         [TestMethod]
-        public void AssignedByValParameter_ReturnsResult_Assignment()
+        public void EmptyStringLiteral_ReturnsResult_Assignment()
         {
             const string inputCode =
 @"Public Sub Foo(ByRef arg1 As String)
@@ -65,7 +65,7 @@ public void AssignedByValParameter_ReturnsResult_Assignment()
         }
 
         [TestMethod]
-        public void AssignedByValParameter_DoesNotReturnResult()
+        public void NotEmptyStringLiteral_DoesNotReturnResult()
         {
             const string inputCode =
 @"Public Sub Foo(ByRef arg1 As String)
@@ -89,7 +89,7 @@ public void AssignedByValParameter_DoesNotReturnResult()
         }
 
         [TestMethod]
-        public void AssignedByValParameter_QuickFixWorks()
+        public void EmptyStringLiteral_QuickFixWorks()
         {
             const string inputCode =
 @"Public Sub Foo(ByRef arg1 As String)

RubberduckTests/Inspections/EncapsulatePublicFieldInspectionTests.cs

@@ -0,0 +1,123 @@
+using System.Linq;
+using Microsoft.Vbe.Interop;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Moq;
+using Rubberduck.Inspections;
+using Rubberduck.Parsing.VBA;
+using Rubberduck.VBEditor.Extensions;
+using Rubberduck.VBEditor.VBEHost;
+using RubberduckTests.Mocks;
+
+namespace RubberduckTests.Inspections
+{
+    [TestClass]
+    public class EncapsulatePublicFieldInspectionTests
+    {
+        [TestMethod]
+        public void PublicField_ReturnsResult()
+        {
+            const string inputCode =
+@"Public fizz As Boolean";
+
+            //Arrange
+            var builder = new MockVbeBuilder();
+            VBComponent component;
+            var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
+            var mockHost = new Mock<IHostApplication>();
+            mockHost.SetupAllProperties();
+            var parser = new RubberduckParser(vbe.Object, new RubberduckParserState());
+
+            parser.Parse();
+
+            var inspection = new EncapsulatePublicFieldInspection(parser.State);
+            var inspectionResults = inspection.GetInspectionResults();
+
+            Assert.AreEqual(1, inspectionResults.Count());
+        }
+
+        [TestMethod]
+        public void MultiplePublicFields_ReturnMultipleResult()
+        {
+            const string inputCode =
+@"Public fizz As Boolean
+Public buzz As Integer, _
+       bazz As Integer";
+
+            //Arrange
+            var builder = new MockVbeBuilder();
+            VBComponent component;
+            var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
+            var mockHost = new Mock<IHostApplication>();
+            mockHost.SetupAllProperties();
+            var parser = new RubberduckParser(vbe.Object, new RubberduckParserState());
+
+            parser.Parse();
+
+            var inspection = new EncapsulatePublicFieldInspection(parser.State);
+            var inspectionResults = inspection.GetInspectionResults();
+
+            Assert.AreEqual(3, inspectionResults.Count());
+        }
+
+        [TestMethod]
+        public void PrivateField_DoesNotReturnResult()
+        {
+            const string inputCode =
+@"Private fizz As Boolean";
+
+            //Arrange
+            var builder = new MockVbeBuilder();
+            VBComponent component;
+            var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
+            var mockHost = new Mock<IHostApplication>();
+            mockHost.SetupAllProperties();
+            var parser = new RubberduckParser(vbe.Object, new RubberduckParserState());
+
+            parser.Parse();
+
+            var inspection = new EncapsulatePublicFieldInspection(parser.State);
+            var inspectionResults = inspection.GetInspectionResults();
+
+            Assert.AreEqual(0, inspectionResults.Count());
+        }
+
+        [TestMethod]
+        public void PublicNonField_DoesNotReturnResult()
+        {
+            const string inputCode =
+@"Public Sub Foo(ByRef arg1 As String)
+End Sub";
+
+            //Arrange
+            var builder = new MockVbeBuilder();
+            VBComponent component;
+            var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
+            var mockHost = new Mock<IHostApplication>();
+            mockHost.SetupAllProperties();
+            var parser = new RubberduckParser(vbe.Object, new RubberduckParserState());
+
+            parser.Parse();
+
+            var inspection = new EncapsulatePublicFieldInspection(parser.State);
+            var inspectionResults = inspection.GetInspectionResults();
+
+            Assert.AreEqual(0, inspectionResults.Count());
+        }
+
+        [TestMethod]
+        public void InspectionType()
+        {
+            var inspection = new EncapsulatePublicFieldInspection(null);
+            Assert.AreEqual(CodeInspectionType.MaintainabilityAndReadabilityIssues, inspection.InspectionType);
+        }
+
+        [TestMethod]
+        public void InspectionName()
+        {
+            const string inspectionName = "EncapsulatePublicFieldInspection";
+            var inspection = new EncapsulatePublicFieldInspection(null);
+
+            Assert.AreEqual(inspectionName, inspection.Name);
+        }
+    }
+}

RubberduckTests/RubberduckTests.csproj

@@ -72,6 +72,7 @@
   <ItemGroup>
     <Compile Include="ComponentTypeExtensionTests.cs" />
     <Compile Include="ConfigurationTests.cs" />
+    <Compile Include="Inspections\EncapsulatePublicFieldInspectionTests.cs" />
     <Compile Include="Inspections\MoveFieldCloserToUsageInspectionTests.cs" />
     <Compile Include="Inspections\AssignedByValParameterInspectionTests.cs" />
     <Compile Include="Inspections\ConstantNotUsedInspectionTests.cs" />