Skip to content

Commit b5979cf

Browse files
committed
Addressed some review comments.
1 parent f1ba539 commit b5979cf

File tree

7 files changed

+20
-28
lines changed

7 files changed

+20
-28
lines changed

RetailCoder.VBE/Navigation/CodeExplorer/CodeExplorerViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ private void UpdateNodes(IEnumerable<CodeExplorerItemViewModel> oldList, IEnumer
360360
}
361361
}
362362

363-
private void ParserState_ModuleStateChanged(object sender, Parsing.ParseProgressEventArgs e)
363+
private void ParserState_ModuleStateChanged(object sender, ParseProgressEventArgs e)
364364
{
365365
// if we are resolving references, we already have the declarations and don't need to display error
366366
if (!(e.State == ParserState.Error ||

Rubberduck.Inspections/Inspector.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public async Task<IEnumerable<IInspectionResult>> FindIssuesAsync(RubberduckPars
102102

103103
try
104104
{
105-
await Task.Run(() => RunInspectionsInParallel(inspectionsToRun, allIssues, token), token);
105+
await Task.Run(() => RunInspectionsInParallel(inspectionsToRun, allIssues, token));
106106
}
107107
catch (AggregateException exception)
108108
{

Rubberduck.Parsing/IParseResultProvider.cs

Lines changed: 0 additions & 23 deletions
This file was deleted.

Rubberduck.Parsing/Rubberduck.Parsing.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,6 @@
233233
<Compile Include="Binding\Expressions\SimpleNameExpression.cs" />
234234
<Compile Include="Binding\Bindings\SimpleNameTypeBinding.cs" />
235235
<Compile Include="ComHelper.cs" />
236-
<Compile Include="IParseResultProvider.cs" />
237236
<Compile Include="IParseCoordinator.cs" />
238237
<Compile Include="ParsingText.Designer.cs">
239238
<AutoGen>True</AutoGen>

Rubberduck.Parsing/VBA/RubberduckParserState.cs

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,22 @@
2424

2525
namespace Rubberduck.Parsing.VBA
2626
{
27+
public class ParseProgressEventArgs : EventArgs
28+
{
29+
public QualifiedModuleName Module { get; }
30+
public ParserState State { get; }
31+
public ParserState OldState { get; }
32+
public CancellationToken Token { get; }
33+
34+
public ParseProgressEventArgs(QualifiedModuleName module, ParserState state, ParserState oldState, CancellationToken token)
35+
{
36+
Module = module;
37+
State = state;
38+
OldState = oldState;
39+
Token = token;
40+
}
41+
}
42+
2743
public class ParserStateEventArgs : EventArgs
2844
{
2945
public ParserStateEventArgs(ParserState state, CancellationToken token)
@@ -682,7 +698,7 @@ public void ClearStateCache(string projectId)
682698
foreach (var moduleState in _moduleStates.Where(moduleState => moduleState.Key.ProjectId == projectId))
683699
{
684700
var qualifiedModuleName = moduleState.Key;
685-
if (qualifiedModuleName.ComponentType == ComponentType.Undefined && qualifiedModuleName.ComponentType == ComponentType.ComComponent)
701+
if (qualifiedModuleName.ComponentType == ComponentType.Undefined || qualifiedModuleName.ComponentType == ComponentType.ComComponent)
686702
{
687703
if (_moduleStates.TryRemove(qualifiedModuleName, out var state))
688704
{

RubberduckTests/RubberduckTests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@
152152
<Compile Include="QuickFixes\AddStepOneQuickFixTests.cs" />
153153
<Compile Include="QuickFixes\RemoveStepOneQuickFixTests.cs" />
154154
<Compile Include="QuickFixes\RemoveUnassignedIdentifierQuickFixTests.cs" />
155-
<Compile Include="QuickFixes\RemoveUnassignedVariableUsageQuickFix.cs" />
155+
<Compile Include="QuickFixes\RemoveUnassignedVariableUsageQuickFixTests.cs" />
156156
<Compile Include="QuickFixes\ReplaceObsoleteErrorStatementQuickFixTests.cs" />
157157
<Compile Include="Inspections\RedundantByRefModifierInspectionTests.cs" />
158158
<Compile Include="Inspections\UndeclaredVariableInspectionTests.cs" />

0 commit comments

Comments
 (0)