Skip to content

Commit b527bb3

Browse files
committed
Remove experimental attribute from empty block inspections
Also sets the severity to Hint.
1 parent e7c76e3 commit b527bb3

File tree

7 files changed

+4
-20
lines changed

7 files changed

+4
-20
lines changed

Rubberduck.CodeAnalysis/Inspections/Abstract/EmptyBlockInspectionBase.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@ namespace Rubberduck.CodeAnalysis.Inspections.Abstract
1010
internal abstract class EmptyBlockInspectionBase<TContext> : ParseTreeInspectionBase<TContext>
1111
where TContext : ParserRuleContext
1212
{
13-
protected EmptyBlockInspectionBase(IDeclarationFinderProvider declarationFinderProvider)
13+
protected EmptyBlockInspectionBase(IDeclarationFinderProvider declarationFinderProvider)
1414
: base(declarationFinderProvider)
15-
{}
15+
{
16+
Severity = CodeInspectionSeverity.Hint;
17+
}
1618

1719
protected class EmptyBlockInspectionListenerBase : InspectionListenerBase<TContext>
1820
{

Rubberduck.CodeAnalysis/Inspections/Concrete/EmptyBlock/EmptyCaseBlockInspection.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
using Antlr4.Runtime.Misc;
22
using Rubberduck.CodeAnalysis.Inspections.Abstract;
33
using Rubberduck.Parsing;
4-
using Rubberduck.Parsing.Common;
54
using Rubberduck.Parsing.Grammar;
65
using Rubberduck.Parsing.VBA;
7-
using Rubberduck.Resources.Experimentals;
86
using Rubberduck.Resources.Inspections;
97

108
namespace Rubberduck.CodeAnalysis.Inspections.Concrete.EmptyBlock
@@ -38,7 +36,6 @@ namespace Rubberduck.CodeAnalysis.Inspections.Concrete.EmptyBlock
3836
/// End Sub
3937
/// ]]>
4038
/// </example>
41-
[Experimental(nameof(ExperimentalNames.EmptyBlockInspections))]
4239
internal sealed class EmptyCaseBlockInspection : EmptyBlockInspectionBase<VBAParser.CaseClauseContext>
4340
{
4441
public EmptyCaseBlockInspection(IDeclarationFinderProvider declarationFinderProvider)

Rubberduck.CodeAnalysis/Inspections/Concrete/EmptyBlock/EmptyDoWhileBlockInspection.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
using Antlr4.Runtime.Misc;
22
using Rubberduck.CodeAnalysis.Inspections.Abstract;
33
using Rubberduck.Parsing;
4-
using Rubberduck.Parsing.Common;
54
using Rubberduck.Parsing.Grammar;
65
using Rubberduck.Parsing.VBA;
7-
using Rubberduck.Resources.Experimentals;
86
using Rubberduck.Resources.Inspections;
97

108
namespace Rubberduck.CodeAnalysis.Inspections.Concrete.EmptyBlock
@@ -33,7 +31,6 @@ namespace Rubberduck.CodeAnalysis.Inspections.Concrete.EmptyBlock
3331
/// End Sub
3432
/// ]]>
3533
/// </example>
36-
[Experimental(nameof(ExperimentalNames.EmptyBlockInspections))]
3734
internal sealed class EmptyDoWhileBlockInspection : EmptyBlockInspectionBase<VBAParser.DoLoopStmtContext>
3835
{
3936
public EmptyDoWhileBlockInspection(IDeclarationFinderProvider declarationFinderProvider)

Rubberduck.CodeAnalysis/Inspections/Concrete/EmptyBlock/EmptyElseBlockInspection.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
using Antlr4.Runtime.Misc;
22
using Rubberduck.CodeAnalysis.Inspections.Abstract;
33
using Rubberduck.Parsing;
4-
using Rubberduck.Parsing.Common;
54
using Rubberduck.Parsing.Grammar;
65
using Rubberduck.Parsing.VBA;
7-
using Rubberduck.Resources.Experimentals;
86
using Rubberduck.Resources.Inspections;
97

108
namespace Rubberduck.CodeAnalysis.Inspections.Concrete.EmptyBlock
@@ -35,7 +33,6 @@ namespace Rubberduck.CodeAnalysis.Inspections.Concrete.EmptyBlock
3533
/// End Sub
3634
/// ]]>
3735
/// </example>
38-
[Experimental(nameof(ExperimentalNames.EmptyBlockInspections))]
3936
internal sealed class EmptyElseBlockInspection : EmptyBlockInspectionBase<VBAParser.ElseBlockContext>
4037
{
4138
public EmptyElseBlockInspection(IDeclarationFinderProvider declarationFinderProvider)

Rubberduck.CodeAnalysis/Inspections/Concrete/EmptyBlock/EmptyForEachBlockInspection.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
using Antlr4.Runtime.Misc;
22
using Rubberduck.CodeAnalysis.Inspections.Abstract;
33
using Rubberduck.Parsing;
4-
using Rubberduck.Parsing.Common;
54
using Rubberduck.Parsing.Grammar;
65
using Rubberduck.Parsing.VBA;
7-
using Rubberduck.Resources.Experimentals;
86
using Rubberduck.Resources.Inspections;
97

108
namespace Rubberduck.CodeAnalysis.Inspections.Concrete.EmptyBlock
@@ -35,7 +33,6 @@ namespace Rubberduck.CodeAnalysis.Inspections.Concrete.EmptyBlock
3533
/// End Sub
3634
/// ]]>
3735
/// </example>
38-
[Experimental(nameof(ExperimentalNames.EmptyBlockInspections))]
3936
internal sealed class EmptyForEachBlockInspection : EmptyBlockInspectionBase<VBAParser.ForEachStmtContext>
4037
{
4138
public EmptyForEachBlockInspection(IDeclarationFinderProvider declarationFinderProvider)

Rubberduck.CodeAnalysis/Inspections/Concrete/EmptyBlock/EmptyForLoopBlockInspection.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
using Antlr4.Runtime.Misc;
22
using Rubberduck.CodeAnalysis.Inspections.Abstract;
33
using Rubberduck.Parsing;
4-
using Rubberduck.Parsing.Common;
54
using Rubberduck.Parsing.Grammar;
65
using Rubberduck.Parsing.VBA;
7-
using Rubberduck.Resources.Experimentals;
86
using Rubberduck.Resources.Inspections;
97

108
namespace Rubberduck.CodeAnalysis.Inspections.Concrete.EmptyBlock
@@ -35,7 +33,6 @@ namespace Rubberduck.CodeAnalysis.Inspections.Concrete.EmptyBlock
3533
/// End Sub
3634
/// ]]>
3735
/// </example>
38-
[Experimental(nameof(ExperimentalNames.EmptyBlockInspections))]
3936
internal sealed class EmptyForLoopBlockInspection : EmptyBlockInspectionBase<VBAParser.ForNextStmtContext>
4037
{
4138
public EmptyForLoopBlockInspection(IDeclarationFinderProvider declarationFinderProvider)

Rubberduck.CodeAnalysis/Inspections/Concrete/EmptyBlock/EmptyWhileWendBlockInspection.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
using Antlr4.Runtime.Misc;
22
using Rubberduck.CodeAnalysis.Inspections.Abstract;
33
using Rubberduck.Parsing;
4-
using Rubberduck.Parsing.Common;
54
using Rubberduck.Parsing.Grammar;
65
using Rubberduck.Parsing.VBA;
7-
using Rubberduck.Resources.Experimentals;
86
using Rubberduck.Resources.Inspections;
97

108
namespace Rubberduck.CodeAnalysis.Inspections.Concrete.EmptyBlock
@@ -33,7 +31,6 @@ namespace Rubberduck.CodeAnalysis.Inspections.Concrete.EmptyBlock
3331
/// End Sub
3432
/// ]]>
3533
/// </example>
36-
[Experimental(nameof(ExperimentalNames.EmptyBlockInspections))]
3734
internal sealed class EmptyWhileWendBlockInspection : EmptyBlockInspectionBase<VBAParser.WhileWendStmtContext>
3835
{
3936
public EmptyWhileWendBlockInspection(IDeclarationFinderProvider declarationFinderProvider)

0 commit comments

Comments
 (0)