Merge pull request #4419 from bclothier/ChainedWrapperEnhancement

Improve the messaging for the chained wrapper analyzer rule

Author: Hosch250

RubberduckCodeAnalysis/ChainedWrapperAnalyzer.cs

@@ -51,7 +51,10 @@ private static void AnalyzeSymbol(SyntaxNodeAnalysisContext context)
             if (expInterfaces.Value.Any(a => a.ToDisplayString() == "Rubberduck.VBEditor.SafeComWrappers.Abstract.ISafeComWrapper") &&
                 nameInterfaces.Value.Any(a => a.ToDisplayString() == "Rubberduck.VBEditor.SafeComWrappers.Abstract.ISafeComWrapper"))
             {
-                var diagnostic = Diagnostic.Create(ChainedWrapperRule, node.GetLocation());
+                var targetType = context.SemanticModel.GetTypeInfo(nameValue).Type.Name;
+                var containingType = context.SemanticModel.GetTypeInfo(node.Expression).Type.Name;
+                var diagnostic = Diagnostic.Create(ChainedWrapperRule, node.GetLocation(), targetType, containingType, node.GetText());
+                
                 context.ReportDiagnostic(diagnostic);
             }
         }

RubberduckCodeAnalysis/Resources.resx

@@ -121,10 +121,10 @@
     <value>COM Management</value>
   </data>
   <data name="ChainedWrapperDescription" xml:space="preserve">
-    <value>Chained Wrappers</value>
+    <value>All types derived from SafeComWrappers should not be chained as it leaks unmanaged resources. Use an explicit local variable for each chained member.</value>
   </data>
   <data name="ChainedWrapperMessageFormat" xml:space="preserve">
-    <value>Chained Wrappers</value>
+    <value>The type '{0}' derives from a SafeComWrapper base. It is called via other SafeComWrapper-derived type '{1}' in the expression '{2}'.</value>
   </data>
   <data name="ChainedWrapperTitle" xml:space="preserve">
     <value>Chained Wrappers</value>