removed possible invalidcastexception / R# warning

retailcoder · retailcoder · commit b39441e60496 · 2016-12-28T00:28:42.000-05:00
diff --git a/Rubberduck.Parsing/Symbols/AliasDeclarations.cs b/Rubberduck.Parsing/Symbols/AliasDeclarations.cs
@@ -529,10 +529,9 @@ private FunctionDeclaration UCaseFunction()
 
             private static void AddParametersToAliasesFromReferencedFunctions(List<FunctionDeclaration> functionAliases, List<Declaration> referencedFunctions)
             {
-                // ReSharper disable once PossibleInvalidCastExceptionInForeachLoop
                 foreach (var alias in functionAliases)
                 {
-                    foreach (var parameter in ((FunctionDeclaration)referencedFunctions.Single(s => s.IdentifierName == "_B_var_" + alias.IdentifierName)).Parameters)
+                    foreach (var parameter in referencedFunctions.OfType<FunctionDeclaration>().Single(s => s.IdentifierName == "_B_var_" + alias.IdentifierName).Parameters)
                     {
                         alias.AddParameter(parameter);
                     }

Original file line number	Diff line number	Diff line change
`@@ -529,10 +529,9 @@ private FunctionDeclaration UCaseFunction()`
`529`	`529`
`530`	`530`	`private static void AddParametersToAliasesFromReferencedFunctions(List<FunctionDeclaration> functionAliases, List<Declaration> referencedFunctions)`
`531`	`531`	`{`
`532`		`- // ReSharper disable once PossibleInvalidCastExceptionInForeachLoop`
`533`	`532`	`foreach (var alias in functionAliases)`
`534`	`533`	`{`
`535`		`- foreach (var parameter in ((FunctionDeclaration)referencedFunctions.Single(s => s.IdentifierName == "_B_var_" + alias.IdentifierName)).Parameters)`
	`534`	`+ foreach (var parameter in referencedFunctions.OfType<FunctionDeclaration>().Single(s => s.IdentifierName == "_B_var_" + alias.IdentifierName).Parameters)`
`536`	`535`	`{`
`537`	`536`	`alias.AddParameter(parameter);`
`538`	`537`	`}`