fixed possible NRE

retailcoder · retailcoder · commit b25458a0b873 · 2018-11-25T01:30:35.000-05:00
diff --git a/Rubberduck.CodeAnalysis/Inspections/Concrete/NonReturningFunctionInspection.cs b/Rubberduck.CodeAnalysis/Inspections/Concrete/NonReturningFunctionInspection.cs
@@ -54,8 +54,9 @@ private bool IsAssignedByRefArgument(Declaration enclosingProcedure, IdentifierR
             var parameter = State.DeclarationFinder.FindParameterFromArgument(argExpression, enclosingProcedure);
 
             // note: not recursive, by design.
-            return (parameter.IsImplicitByRef || parameter.IsByRef)
-                && parameter.References.Any(r => r.IsAssignment);
+            return parameter != null
+                   && (parameter.IsImplicitByRef || parameter.IsByRef)
+                   && parameter.References.Any(r => r.IsAssignment);
         }
 
         private bool IsReturningUserDefinedType(Declaration member)
diff --git a/Rubberduck.CodeAnalysis/Inspections/Concrete/VariableNotAssignedInspection.cs b/Rubberduck.CodeAnalysis/Inspections/Concrete/VariableNotAssignedInspection.cs
@@ -40,7 +40,8 @@ private bool IsAssignedByRefArgument(Declaration enclosingProcedure, IdentifierR
             var parameter = State.DeclarationFinder.FindParameterFromArgument(argExpression, enclosingProcedure);
 
             // note: not recursive, by design.
-            return (parameter.IsImplicitByRef || parameter.IsByRef)
+            return parameter != null
+                   && (parameter.IsImplicitByRef || parameter.IsByRef)
                    && parameter.References.Any(r => r.IsAssignment);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,8 @@ private bool IsAssignedByRefArgument(Declaration enclosingProcedure, IdentifierR`
`40`	`40`	`var parameter = State.DeclarationFinder.FindParameterFromArgument(argExpression, enclosingProcedure);`
`41`	`41`
`42`	`42`	`// note: not recursive, by design.`
`43`		`- return (parameter.IsImplicitByRef \|\| parameter.IsByRef)`
	`43`	`+ return parameter != null`
	`44`	`+ && (parameter.IsImplicitByRef \|\| parameter.IsByRef)`
`44`	`45`	`&& parameter.References.Any(r => r.IsAssignment);`
`45`	`46`	`}`
`46`	`47`	`}`