Generate temp filenames in AttributeParser to avoid collisions. Ref #2802

Author: comintern

RetailCoder.VBE/App.cs

@@ -81,6 +81,27 @@ private static void EnsureLogFolderPathExists()
             }
         }
 
+        private static void EnsureTempPathExists()
+        {
+            // This is required by the parser - allow this to throw. 
+            if (!Directory.Exists(ApplicationConstants.RUBBERDUCK_TEMP_PATH))
+            {
+                Directory.CreateDirectory(ApplicationConstants.RUBBERDUCK_TEMP_PATH);
+            }
+            // The parser swallows the error if deletions fail - clean up any temp files on startup
+            try
+            {
+                foreach (var file in new DirectoryInfo(ApplicationConstants.RUBBERDUCK_TEMP_PATH).GetFiles())
+                {
+                    file.Delete();
+                }
+            }
+            catch
+            {
+                // Yeah, don't care here either.
+            }
+        }
+
         private void UpdateLoggingLevel()
         {
             LogLevelHelper.SetMinimumLogLevel(LogLevel.FromOrdinal(_config.UserSettings.GeneralSettings.MinimumLogLevel));
@@ -89,6 +110,7 @@ private void UpdateLoggingLevel()
         public void Startup()
         {
             EnsureLogFolderPathExists();
+            EnsureTempPathExists();
             LogRubberduckSart();
             LoadConfig();
             CheckForLegacyIndenterSettings();

RetailCoder.VBE/Common/ApplicationConstants.cs

@@ -7,5 +7,6 @@ public static class ApplicationConstants
     {
         public static readonly string RUBBERDUCK_FOLDER_PATH = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), "Rubberduck");
         public static readonly string LOG_FOLDER_PATH = Path.Combine(RUBBERDUCK_FOLDER_PATH, "Logs");
+        public static readonly string RUBBERDUCK_TEMP_PATH = Path.Combine(Path.GetTempPath(), "Rubberduck");
     }
 }

RetailCoder.VBE/Common/ModuleExporter.cs

@@ -1,4 +1,5 @@
-using System.IO;
+using System;
+using System.IO;
 using System.Reflection;
 using Rubberduck.Parsing.VBA;
 using Rubberduck.VBEditor.SafeComWrappers.Abstract;
@@ -7,18 +8,22 @@ namespace Rubberduck.Common
 {
     public class ModuleExporter : IModuleExporter
     {
+        public bool TempFile { get; private set; }
+
         public string ExportPath
         {
             get
             {
-                var assemblyLocation = Assembly.GetAssembly(typeof(App)).Location;
-                return Path.GetDirectoryName(assemblyLocation);
+                return TempFile
+                    ? ApplicationConstants.RUBBERDUCK_TEMP_PATH
+                    : Path.GetDirectoryName(Assembly.GetAssembly(typeof(App)).Location);
             }
         }
 
-        public string Export(IVBComponent component)
+        public string Export(IVBComponent component, bool tempFile = false)
         {
-            return component.ExportAsSourceFile(ExportPath);
+            TempFile = tempFile;
+            return component.ExportAsSourceFile(ExportPath, tempFile);
         }
     }
 }

Rubberduck.Parsing/VBA/AttributeParser.cs

@@ -32,14 +32,22 @@ public AttributeParser(IModuleExporter exporter, Func<IVBAPreprocessor> preproce
         public IDictionary<Tuple<string, DeclarationType>, Attributes> Parse(IVBComponent component, CancellationToken token)
         {
             token.ThrowIfCancellationRequested();
-            var path = _exporter.Export(component);
+            var path = _exporter.Export(component, true);
             if (!File.Exists(path))
             {
                 // a document component without any code wouldn't be exported (file would be empty anyway).
                 return new Dictionary<Tuple<string, DeclarationType>, Attributes>();
             }
             var code = File.ReadAllText(path);
-            File.Delete(path);
+            try
+            {
+                File.Delete(path);
+            }
+            catch
+            {
+                // Meh.
+            }
+           
             token.ThrowIfCancellationRequested();
 
             var type = component.Type == ComponentType.StandardModule

Rubberduck.Parsing/VBA/IModuleExporter.cs

@@ -5,12 +5,14 @@ namespace Rubberduck.Parsing.VBA
     public interface IModuleExporter
     {
         string ExportPath { get; }
+        bool TempFile { get; }
 
         /// <summary>
         /// Exports the specified component and returns the path to the created file.
         /// </summary>
         /// <param name="component">The module to export.</param>
+        /// <param name="tempFile">True if a unique temp file name should be generated.</param>
         /// <returns>Returns a string containing the path and filename of the created file.</returns>
-        string Export(IVBComponent component);
+        string Export(IVBComponent component, bool tempFile = false);
     }
 }

Rubberduck.VBEEditor/SafeComWrappers/Abstract/IVBComponent.cs

@@ -20,7 +20,7 @@ public interface IVBComponent : ISafeComWrapper, IEquatable<IVBComponent>
         IWindow DesignerWindow();
         void Activate();
         void Export(string path);
-        string ExportAsSourceFile(string folder);
+        string ExportAsSourceFile(string folder, bool tempFile = false);
 
         IVBProject ParentProject { get; }
     }

Rubberduck.VBEEditor/SafeComWrappers/VB6/VBComponent.cs

@@ -128,9 +128,12 @@ public void Export(string path)
         /// Exports the component to the folder. The file name matches the component name and file extension is based on the component's type.
         /// </summary>
         /// <param name="folder">Destination folder for the resulting source file.</param>
-        public string ExportAsSourceFile(string folder)
+        /// <param name="tempFile">True if a unique temp file name should be generated. WARNING: filenames generated with this flag are not persisted.</param>
+        public string ExportAsSourceFile(string folder, bool tempFile = false)
         {
-            var fullPath = Path.Combine(folder, Name + Type.FileExtension());
+            var fullPath = tempFile
+                ? Path.Combine(folder, Path.GetRandomFileName())
+                : Path.Combine(folder, Name + Type.FileExtension());
             switch (Type)
             {
                 case ComponentType.UserForm:

Rubberduck.VBEEditor/SafeComWrappers/VBA/VBComponent.cs

@@ -124,9 +124,12 @@ public void Export(string path)
         /// Exports the component to the folder. The file is name matches the component name and file extension is based on the component's type.
         /// </summary>
         /// <param name="folder">Destination folder for the resulting source file.</param>
-        public string ExportAsSourceFile(string folder)
+        /// <param name="tempFile">True if a unique temp file name should be generated. WARNING: filenames generated with this flag are not persisted.</param>
+        public string ExportAsSourceFile(string folder, bool tempFile = false)
         {
-            var fullPath = Path.Combine(folder, SafeName + Type.FileExtension());
+            var fullPath = tempFile
+                ? Path.Combine(folder, Path.GetRandomFileName())
+                : Path.Combine(folder, SafeName + Type.FileExtension());
             switch (Type)
             {
                 case ComponentType.UserForm: