Clean up selection handling vie ISelectionService in Core and Parsing

Author: MDoerner

Rubberduck.Core/Navigation/RegexSearchReplace/RegexSearchReplace.cs

@@ -92,9 +92,7 @@ private IEnumerable<RegexSearchResult> GetResultsFromModule(ICodeModule module,
 
         private void SetSelection(RegexSearchResult item)
         {
-            var module = item.Module.QualifiedModuleName;
-            _selectionService.TrySetSelection(module, item.Selection);
-            _selectionService.TryActivate(module);
+            _selectionService.TrySetActiveSelection(item.Module.QualifiedModuleName, item.Selection);
         }
 
         private List<RegexSearchResult> SearchSelection(string searchPattern)

Rubberduck.Core/UI/Command/NavigateCommand.cs

@@ -1,6 +1,7 @@
 using System.Runtime.InteropServices;
 using NLog;
 using Rubberduck.Interaction.Navigation;
+using Rubberduck.VBEditor;
 using Rubberduck.VBEditor.Utility;
 
 namespace Rubberduck.UI.Command
@@ -28,10 +29,7 @@ protected override void OnExecute(object parameter)
                 return;
             }
 
-            if (_selectionService.TrySetSelection(param.QualifiedName, param.Selection))
-            {
-                _selectionService.TryActivate(param.QualifiedName);
-            }
+            _selectionService.TrySetActiveSelection(param.QualifiedName, param.Selection);
         }
     }
 }

Rubberduck.Core/UI/IdentifierReferences/IdentifierReferencesListDockablePresenter.cs

@@ -32,10 +32,7 @@ private void BindTarget(Declaration target)
 
         private void OnNavigateIdentifierReference(IdentifierReference reference)
         {
-            if(_selectionService.TrySetSelection(reference.QualifiedModuleName, reference.Selection))
-            {
-                _selectionService.TryActivate(reference.QualifiedModuleName);
-            }
+            _selectionService.TrySetActiveSelection(reference.QualifiedModuleName, reference.Selection);
         }
 
         private void ControlNavigate(object sender, ListItemActionEventArgs e)

Rubberduck.Core/UI/IdentifierReferences/ImplementationsListDockablePresenter.cs

@@ -33,10 +33,7 @@ private void BindTarget(IEnumerable<Declaration> implementations)
 
         private void OnNavigateImplementation(Declaration implementation)
         {
-            if (_selectionService.TrySetSelection(implementation.QualifiedModuleName, implementation.Selection))
-            {
-                _selectionService.TryActivate(implementation.QualifiedModuleName);
-            }
+            _selectionService.TrySetActiveSelection(implementation.QualifiedModuleName, implementation.Selection);
         }
 
         private void ControlNavigate(object sender, ListItemActionEventArgs e)

Rubberduck.Parsing/VBA/ParseErrorEventArgs.cs

@@ -23,10 +23,7 @@ public ParseErrorEventArgs(SyntaxErrorException exception, QualifiedModuleName m
         public void Navigate(ISelectionService selectionService)
         {
             var selection = new Selection(Exception.LineNumber, Exception.Position, Exception.LineNumber, Exception.Position + Exception.OffendingSymbol.Text.Length - 1);
-            if (selectionService.TrySetSelection(_moduleName, selection))
-            {
-                selectionService.TryActivate(_moduleName);
-            }
+            selectionService.TrySetActiveSelection(_moduleName, selection);
         }
     }
 }

Rubberduck.VBEEditor/SourceCodeHandling/CodePaneSourceCodeHandler.cs

@@ -3,7 +3,6 @@
 using System.Linq;
 using Rubberduck.VBEditor.ComManagement;
 using Rubberduck.VBEditor.SafeComWrappers.Abstract;
-using System.Reflection;
 using System.Diagnostics;
 
 namespace Rubberduck.VBEditor.SourceCodeHandling