Settings for experimental inspections will not be displayed

Author: rkapka

RetailCoder.VBE/Settings/CodeInspectionConfigProvider.cs

@@ -17,6 +17,8 @@ public CodeInspectionConfigProvider(IPersistanceService<CodeInspectionSettings>
             _persister = persister;
             _foundInspectionNames = inspectionProvider.Inspections.Select(inspection => inspection.Name).ToHashSet();
             _defaultSettings = new DefaultSettings<CodeInspectionSettings>().Default;
+            // Ignore settings for unknown inpections, for example when using the Experimental attribute
+            _defaultSettings.CodeInspections = _defaultSettings.CodeInspections.Where(setting => _foundInspectionNames.Contains(setting.Name)).ToHashSet();
 
             var defaultNames = _defaultSettings.CodeInspections.Select(x => x.Name);
             var nonDefaultInspections = inspectionProvider.Inspections.Where(inspection => !defaultNames.Contains(inspection.Name));

RubberduckTests/Settings/CodeInspectionConfigProviderTests.cs

@@ -60,13 +60,12 @@ public void UserSettingsAreCombinedWithDefaultSettings()
         [Test]
         public void UserSettingsAreNotDuplicatedWithDefaultSettings()
         {
+            var inspectionMock = new Mock<IInspection>();
+            inspectionMock.Setup(inspection => inspection.Name).Returns("Foo");
             var inspectionProviderMock = new Mock<IInspectionProvider>();
-            inspectionProviderMock.Setup(provider => provider.Inspections).Returns(Enumerable.Empty<IInspection>());
-
-            var defaultSettings = new CodeInspectionConfigProvider(null, inspectionProviderMock.Object).CreateDefaults().CodeInspections;
-            var defaultSetting = defaultSettings.First();
+            inspectionProviderMock.Setup(provider => provider.Inspections).Returns(new[] { inspectionMock.Object });
 
-            var userSetting = new CodeInspectionSetting(defaultSetting.Name, defaultSetting.InspectionType);
+            var userSetting = new CodeInspectionSetting(inspectionMock.Object.Name, inspectionMock.Object.InspectionType);
             var userSettings = new CodeInspectionSettings
             {
                 CodeInspections = new HashSet<CodeInspectionSetting>(new[] { userSetting })
@@ -76,11 +75,9 @@ public void UserSettingsAreNotDuplicatedWithDefaultSettings()
             persisterMock.Setup(persister => persister.Load(It.IsAny<CodeInspectionSettings>())).Returns(userSettings);
 
             var configProvider = new CodeInspectionConfigProvider(persisterMock.Object, inspectionProviderMock.Object);
-
             var settings = configProvider.Create().CodeInspections;
 
-            Assert.AreEqual(defaultSettings.Count, settings.Count);
-            Assert.Contains(userSetting, settings.ToArray());
+            Assert.AreEqual(configProvider.CreateDefaults().CodeInspections.Count, settings.Count);
         }