#1942 - AssignedByValParameter new QuickFix

Added QuickFix to replace ByVal parameter with local copy.  Provides a
dialog to retrieve a user provided name.  Refactored variable name
validations to avoid duplicate code and standardize validations for
'UseMeaningfulName' inspections and user's variable name input for this
quickfix.  Refactored validations to a  POCO 'VariableNameValidator'.

Author: BZngr

RetailCoder.VBE/Inspections/QuickFixes/AssignedByValParameterQuickFix.cs

@@ -23,8 +23,8 @@ public AssignedByValParameterQuickFix(Declaration target, QualifiedSelection sel
             : base(target.Context, selection, InspectionsUI.AssignedByValParameterQuickFix)
         {
             _target = target;
-            _localCopyVariableName = "local" + CapitalizeFirstLetter(_target.IdentifierName);
             _forceUseOfSuggestedName = false;
+            _localCopyVariableName = string.Empty;
 
             _originalCodeLines = GetMethodLines();
         }
@@ -40,7 +40,16 @@ public void TESTONLY_FixUsingAutoGeneratedName()
 
         public override void Fix()
         {
-            GetLocalCopyVariableNameFromUser();
+            if (_forceUseOfSuggestedName)
+            {
+                _localCopyVariableName = AutoSuggestedName();
+                IsCancelled = false;
+            }
+            else
+            {
+                GetLocalCopyVariableNameFromUser();
+            }
+
 
             if (!IsCancelled)
             {
@@ -50,13 +59,6 @@ public override void Fix()
 
         private void GetLocalCopyVariableNameFromUser()
         {
-            if (_forceUseOfSuggestedName)
-            {
-                _localCopyVariableName = AutoSuggestedName();
-                IsCancelled = false;
-                return;
-            }
-
             using (var view = new AssignedByValParameterQuickFixDialog(_originalCodeLines))
             {
                 view.Target = _target;
@@ -139,7 +141,6 @@ private string[] GetMethodLines()
         {
             int zbIndex; //zero-based index
             zbIndex = Selection.Selection.StartLine - 1;
-            //int startLine = Selection.Selection.StartLine;
             string[] allLines = GetModuleLines();
 
             string endStatement = GetEndOfScopeStatementForDeclaration(allLines[zbIndex]);