made inspection resource tests independent of current culture

Author: retailcoder

RubberduckTests/Inspections/GeneralInspectionTests.cs

@@ -1,21 +1,35 @@
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
+using System.Threading;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using Rubberduck.Inspections;
+using Rubberduck.UI;
 
 namespace RubberduckTests.Inspections
 {
     [TestClass]
     public class GeneralInspectionTests
     {
+        [TestInitialize]
+        public void InitResources()
+        {
+            // ensure resources are using an invariant culture.
+            Thread.CurrentThread.CurrentCulture = CultureInfo.InvariantCulture;
+            Thread.CurrentThread.CurrentUICulture = Thread.CurrentThread.CurrentCulture;
+            InspectionsUI.Culture = Thread.CurrentThread.CurrentUICulture;
+            RubberduckUI.Culture = Thread.CurrentThread.CurrentUICulture;
+        }
+
         [TestMethod]
         public void InspectionNameStringsExist()
         {
             var inspections = typeof(InspectionBase).Assembly.GetTypes()
                           .Where(type => type.BaseType == typeof(InspectionBase))
                           .Where(i => string.IsNullOrEmpty(InspectionsUI.ResourceManager.GetString(i.Name + "Name")))
-                          .Select(i => i.Name);
+                          .Select(i => i.Name)
+                          .ToList();
 
             Assert.IsFalse(inspections.Any(), string.Join(Environment.NewLine, inspections));
         }
@@ -26,7 +40,8 @@ public void InspectionMetaStringsExist()
             var inspections = typeof(InspectionBase).Assembly.GetTypes()
                           .Where(type => type.BaseType == typeof(InspectionBase))
                           .Where(i => string.IsNullOrEmpty(InspectionsUI.ResourceManager.GetString(i.Name + "Meta")))
-                          .Select(i => i.Name);
+                          .Select(i => i.Name)
+                          .ToList();
 
             Assert.IsFalse(inspections.Any(), string.Join(Environment.NewLine, inspections));
         }
@@ -46,7 +61,8 @@ public void InspectionResultFormatStringsExist()
                           .Where(type => type.BaseType == typeof(InspectionBase))
                           .Where(i => !inspectionsWithSharedResultFormat.Contains(i.Name) &&
                                       string.IsNullOrEmpty(InspectionsUI.ResourceManager.GetString(i.Name + "ResultFormat")))
-                          .Select(i => i.Name);
+                          .Select(i => i.Name)
+                          .ToList();
 
             Assert.IsFalse(inspections.Any(), string.Join(Environment.NewLine, inspections));
         }
@@ -61,7 +77,8 @@ public void InspectionNameStrings_AreNotFormatted()
                               var value = InspectionsUI.ResourceManager.GetString(i.Name + "Name");
                               return !string.IsNullOrEmpty(value) && value.Contains("{0}");
                           })
-                          .Select(i => i.Name);
+                          .Select(i => i.Name)
+                          .ToList();
 
             Assert.IsFalse(inspections.Any(), string.Join(Environment.NewLine, inspections));
         }