*correctly* fixed IndexOutOfRangeException in ParameterCanBeByValInspection

Author: retailcoder

RetailCoder.VBE/Inspections/Inspector.cs

@@ -5,6 +5,7 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Antlr4.Runtime.Tree;
+using NLog;
 using Rubberduck.Parsing;
 using Rubberduck.Parsing.Grammar;
 using Rubberduck.Parsing.VBA;
@@ -82,7 +83,14 @@ public async Task<IEnumerable<ICodeInspectionResult>> FindIssuesAsync(Rubberduck
                             }
                         }, token)).ToList();
 
-                await Task.WhenAll(inspections);
+                try
+                {
+                    await Task.WhenAll(inspections);
+                }
+                catch (Exception e)
+                {
+                    LogManager.GetCurrentClassLogger().Error(e);
+                }
                 state.OnStatusMessageUpdate(RubberduckUI.ResourceManager.GetString("ParserState_" + state.Status, UI.Settings.Settings.Culture)); // should be "Ready"
                 return allIssues;
             }

RetailCoder.VBE/Inspections/ParameterCanBeByValInspection.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Rubberduck.Common;
@@ -68,6 +69,7 @@ private IEnumerable<ParameterCanBeByValInspectionResult> GetResults(List<Declara
                                 .ThenBy(t => t.Selection.StartColumn)
                                 .ToList();
 
+                if (!declarationParameters.Any()) { continue; }
                 var parametersAreByRef = declarationParameters.Select(s => true).ToList();
 
                 var members = declarationMembers.Any(a => a.DeclarationType == DeclarationType.Event)
@@ -85,9 +87,10 @@ private IEnumerable<ParameterCanBeByValInspectionResult> GetResults(List<Declara
 
                     for (var i = 0; i < parameters.Count; i++)
                     {
-                        parametersAreByRef[i] = parametersAreByRef[i] && !IsUsedAsByRefParam(declarations, parameters[i]) &&
-                            ((VBAParser.ArgContext)parameters[i].Context).BYVAL() == null &&
-                            !parameters[i].References.Any(reference => reference.IsAssignment);
+                        parametersAreByRef[i] = parametersAreByRef[i] &&
+                                                !IsUsedAsByRefParam(declarations, parameters[i]) &&
+                                                ((VBAParser.ArgContext) parameters[i].Context).BYVAL() == null &&
+                                                !parameters[i].References.Any(reference => reference.IsAssignment);
                     }
                 }
 

RubberduckTests/Inspections/ParameterCanBeByValInspectionTests.cs

@@ -3,9 +3,7 @@
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using Moq;
 using Rubberduck.Inspections;
-using Rubberduck.Parsing;
 using Rubberduck.Parsing.VBA;
-using Rubberduck.VBEditor;
 using Rubberduck.VBEditor.Application;
 using Rubberduck.VBEditor.Events;
 using Rubberduck.VBEditor.SafeComWrappers;