Merge pull request #4499 from Vogel612/appveyor-shallow-clone

AppVeyor config updates

Author: bclothier

appveyor.yml

@@ -7,21 +7,25 @@ hosts:
 # enforce crlf fixing
 init:
   git config --global core.autocrlf true
-# restrict how much history we try to grab
-clone_depth: 3
+
+# history limited to 15 commits, since we ran into trouble with a limit of 3
+# the limit can be rather 
+clone_depth: 15
+# explicitly do not shallow-clone. 
+# Line-Endings are wrong on github, because of CRLF fixing
+# shallow-clone would download a zip, which doesn't fix the line-endings for unit-tests
+shallow_clone: false
+
 # ignore a certain subset of files when evaluating build-changes
 skip_commits:
   files:
   - docs/*
   - '**/*.md'
-  # intermediately enable yml changes to trigger builds, because codecov changes only changes the codecov yml ...
-#  - '**/*.yml'
   - license
   - License.rtf
 branches:
   only:
   - master
-  - staging
   - next
 skip_tags: true
 
@@ -44,6 +48,7 @@ dotnet_csproj:
   file: 'RubberduckBaseProject.csproj' # ;*\Rubberduck.Core.csproj'
   version: '{version}'
   assembly_version: '{version}'
+  # patching fails if we try to patch properties we didn't define
   #file_version: '{version}'
   #informational_version: '{version}'
 
@@ -61,24 +66,40 @@ build:
 # Otherwise we might run tests against artifacts that do not exist
 test_script:
   # we use -returntargetcode to fail the build if tests fail
-  - OpenCover.Console.exe -register:user -returntargetcode -target:"nunit3-console.exe" -targetargs:".\RubberduckTests\bin\RubberduckTests.dll" -output:".\Rubberduck_Coverage.xml"
-  - OpenCover.Console.exe -register:user -returntargetcode -target:"nunit3-console.exe" -targetargs:".\RubberduckTestsCodeAnalysis\bin\RubberduckTestsCodeAnalysis.dll" -output:".\RubberduckCodeAnalysis_Coverage.xml"
+  - cmd: OpenCover.Console.exe -register:user -returntargetcode -target:"nunit3-console.exe" -targetargs:".\RubberduckTests\bin\RubberduckTests.dll" -output:".\Rubberduck_Coverage.xml"
+  - cmd: OpenCover.Console.exe -register:user -returntargetcode -target:"nunit3-console.exe" -targetargs:".\RubberduckTestsCodeAnalysis\bin\RubberduckTestsCodeAnalysis.dll" -output:".\RubberduckCodeAnalysis_Coverage.xml"
   # when using test_script, after_test seems to not be executed
-  - codecov -f "Rubberduck_Coverage.xml RubberduckCodeAnalysis_Coverage.xml"
+  - cmd: codecov -f "Rubberduck_Coverage.xml RubberduckCodeAnalysis_Coverage.xml"
 
+# Define the installer-name depending on what branch we're building on
+environment:
+  installer_dir: Rubberduck.Deployment\InnoSetup\Installers\
 for:
-  - branches:
-      only:
-        - next
-    after_test:
-      - iscc /O "Rubberduck.Deployment\InnoSetup\Rubberduck.Installer.Build.iss"
-      - move Rubberduck.Deployment\InnoSetup\Installers\Rubberduck.Setup.exe Rubberduck.Deployment\InnoSetup\Installers\Rubberduck.Setup.%APPVEYOR_BUILD_VERSION%-pre.exe
-  - branches:
-      only:
-        - master
-    after_test:
-      - iscc /O "Rubberduck.Deployment\InnoSetup\Rubberduck.Installer.Build.iss"
-      - move Rubberduck.Deployment\InnoSetup\Installers\Rubberduck.Setup.exe Rubberduck.Deployment\InnoSetup\Installers\Rubberduck.Setup.%APPVEYOR_BUILD_VERSION%-pre.exe
+- 
+  branches:
+    only:
+    - next
+  environment:
+    installer_name: Rubberduck.Setup.%APPVEYOR_BUILD_VERSION%-pre.exe
+- 
+  branches:
+    only:
+    - master
+  environment:
+    installer_name: Rubberduck.Setup.%APPVEYOR_BUILD_VERSION%.exe
+- 
+  branches:
+    except:
+      - master
+      - next
+  environment:
+    # fall back to calling the installer after the branch we're on
+    installer_name: Rubberduck.Setup.%APPVEYOR_BUILD_VERSION%-%APPVEYOR_REPO_BRANCH%.exe
+
+# Create Installers for 
+after_test:
+  - cmd: iscc /O "Rubberduck.Deployment\InnoSetup\Rubberduck.Installer.Build.iss"
+  - cmd: move %INSTALLER_DIR%\Rubberduck.Setup.exe %INSTALLER_DIR%\%INSTALLER_NAME%
 
 # grab the installers we produce and upload them to github :)
 artifacts:
@@ -91,7 +112,7 @@ deploy:
     description: AppVeyor build on [master] - https://ci.appveyor.com/project/rubberduck-vba/rubberduck/build/$(appveyor_build_version)
     auth_token:
       secure: NVAZgFRSk566SP5QDge5gYRWCaLi4NJJPTNk3QengH15wL9iVldfrFOllbzKXExq
-    artifact: Rubberduck.Deployment\InnoSetup\Installers\Rubberduck.Setup.$(appveyor_build_version).exe
+    artifact: $(installer_dir)\$(installer_name)
     draft: true
     prerelease: false
     on:
@@ -102,7 +123,7 @@ deploy:
     description: AppVeyor build on [next] - https://ci.appveyor.com/project/rubberduck-vba/rubberduck/build/$(appveyor_build_version)
     auth_token:
       secure: NVAZgFRSk566SP5QDge5gYRWCaLi4NJJPTNk3QengH15wL9iVldfrFOllbzKXExq
-    artifact: Rubberduck.Deployment\InnoSetup\Installers\Rubberduck.Setup.$(appveyor_build_version)-pre.exe
+    artifact: $(installer_dir)\$(installer_name)
     draft: false
     prerelease: true
     on: