Actually catch the right exception at the correct place

COMExceptions were already handled in FindChildByTag in AppCommandBar. The problem is that the faulty registration causes an InvalidCastException.

Author: MDoerner

Rubberduck.Core/UI/Command/MenuItems/CommandBars/AppCommandBarBase.cs

@@ -37,7 +37,13 @@ protected ICommandMenuItem FindChildByTag(string tag)
             }
             catch (COMException exception)
             {
-                Logger.Error(exception,$"COMException while finding child with tag '{tag}'.");
+                Logger.Error(exception, $"COMException while finding child with tag '{tag}' in the command bar.");
+            }
+            catch (InvalidCastException exception)
+            {
+                //This exception will be encountered whenever the registration of the command bar control not correct in the system.
+                //See issue #5349 at https://github.com/rubberduck-vba/Rubberduck/issues/5349
+                Logger.Error(exception, $"Invalid cast exception while finding child with tag '{tag}' in the command bar.");
             }
             return null;
         }

Rubberduck.Core/UI/Command/MenuItems/CommandBars/RubberduckCommandBar.cs

@@ -99,49 +99,39 @@ public void SetStatusLabelCaption(ParserState state, int? errorCount = null)
 
         private void SetStatusLabelCaption(string caption, int? errorCount = null)
         {
-            //This try-catch block guarantees that problems with the COM registration of the command bar classes
-            //only affect the status label text instead of aborting the status change or even crashing the host.
-            //See issue #5349 at https://github.com/rubberduck-vba/Rubberduck/issues/5349
-            try
+            var reparseCommandButton =
+                FindChildByTag(typeof(ReparseCommandMenuItem).FullName) as ReparseCommandMenuItem;
+            if (reparseCommandButton == null)
             {
-                var reparseCommandButton =
-                    FindChildByTag(typeof(ReparseCommandMenuItem).FullName) as ReparseCommandMenuItem;
-                if (reparseCommandButton == null)
-                {
-                    return;
-                }
+                return;
+            }
 
-                var showErrorsCommandButton =
-                    FindChildByTag(typeof(ShowParserErrorsCommandMenuItem).FullName) as ShowParserErrorsCommandMenuItem;
-                if (showErrorsCommandButton == null)
-                {
-                    return;
-                }
+            var showErrorsCommandButton =
+                FindChildByTag(typeof(ShowParserErrorsCommandMenuItem).FullName) as ShowParserErrorsCommandMenuItem;
+            if (showErrorsCommandButton == null)
+            {
+                return;
+            }
 
-                _uiDispatcher.Invoke(() =>
+            _uiDispatcher.Invoke(() =>
+            {
+                try
                 {
-                    try
+                    reparseCommandButton.SetCaption(caption);
+                    reparseCommandButton.SetToolTip(string.Format(RubberduckUI.ReparseToolTipText, caption));
+                    if (errorCount.HasValue && errorCount.Value > 0)
                     {
-                        reparseCommandButton.SetCaption(caption);
-                        reparseCommandButton.SetToolTip(string.Format(RubberduckUI.ReparseToolTipText, caption));
-                        if (errorCount.HasValue && errorCount.Value > 0)
-                        {
-                            showErrorsCommandButton.SetToolTip(
-                                string.Format(RubberduckUI.ParserErrorToolTipText, errorCount.Value));
-                        }
+                        showErrorsCommandButton.SetToolTip(
+                            string.Format(RubberduckUI.ParserErrorToolTipText, errorCount.Value));
                     }
-                    catch (Exception exception)
-                    {
-                        Logger.Error(exception,
-                            "Exception thrown trying to set the status label caption on the UI thread.");
-                    }
-                });
-                Localize();
-            }
-            catch (COMException exception)
-            {
-                Logger.Error(exception, "COMException thrown trying to set the status label caption.");
-            }
+                }
+                catch (Exception exception)
+                {
+                    Logger.Error(exception,
+                        "Exception thrown trying to set the status label caption on the UI thread.");
+                }
+            });
+            Localize();
         }
 
         private void SetContextSelectionCaption(string caption, int contextReferenceCount, string description)