return immediately if Set keyword is already present

retailcoder · retailcoder · commit a47c49b326ce · 2018-01-28T14:54:50.000-05:00
diff --git a/Rubberduck.Inspections/VariableRequiresSetAssignmentEvaluator.cs b/Rubberduck.Inspections/VariableRequiresSetAssignmentEvaluator.cs
@@ -28,7 +28,7 @@ public static IEnumerable<Declaration> GetDeclarationsPotentiallyRequiringSetAss
         public static bool NeedsSetKeywordAdded(IdentifierReference reference, RubberduckParserState state)
         {
             var setStmtContext = reference.Context.GetAncestor<VBAParser.SetStmtContext>();
-            return RequiresSetAssignment(reference, state) && setStmtContext == null;
+            return setStmtContext == null && RequiresSetAssignment(reference, state);
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public static IEnumerable<Declaration> GetDeclarationsPotentiallyRequiringSetAss`
`28`	`28`	`public static bool NeedsSetKeywordAdded(IdentifierReference reference, RubberduckParserState state)`
`29`	`29`	`{`
`30`	`30`	`var setStmtContext = reference.Context.GetAncestor<VBAParser.SetStmtContext>();`
`31`		`- return RequiresSetAssignment(reference, state) && setStmtContext == null;`
	`31`	`+ return setStmtContext == null && RequiresSetAssignment(reference, state);`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`/// <summary>`