Fix bug

Author: Hosch250

RetailCoder.VBE/Root/RubberduckIoCInstaller.cs

@@ -156,10 +156,10 @@ private void RegisterConfiguration(IWindsorContainer container, Assembly[] assem
         {
             foreach (var assembly in assembliesToRegister)
             {
-                var assemblyClasses = assembly.GetTypes()
-                    .Where(w => _initialSettings.EnableExperimentalFeatures || Attribute.IsDefined(w, typeof(ExperimentalAttribute)));
+                var assemblyTypes = assembly.DefinedTypes
+                    .Where(w => _initialSettings.EnableExperimentalFeatures || !Attribute.IsDefined(w, typeof(ExperimentalAttribute)));
 
-                container.Register(Classes.From(assemblyClasses)
+                container.Register(Classes.From(assemblyTypes)
                     .InSameNamespaceAs<Configuration>()
                     .WithService.AllInterfaces()
                     .LifestyleSingleton());
@@ -189,10 +189,12 @@ private void ApplyDefaultInterfaceConvention(IWindsorContainer container, Assemb
         {
             foreach (var assembly in assembliesToRegister)
             {
-                var assemblyClasses = assembly.GetTypes()
-                    .Where(w => _initialSettings.EnableExperimentalFeatures || Attribute.IsDefined(w, typeof(ExperimentalAttribute)));
+                var assemblyTypes = assembly.DefinedTypes
+                    .Where(w => _initialSettings.EnableExperimentalFeatures || !Attribute.IsDefined(w, typeof(ExperimentalAttribute)));
+
+                assemblyTypes.Any(t => t.Name == nameof(IMessageBox));
 
-                container.Register(Classes.From(assemblyClasses)
+                container.Register(Classes.From(assemblyTypes)
                     .Where(type => type.Namespace != null
                                    && !type.Namespace.StartsWith("Rubberduck.VBEditor.SafeComWrappers")
                                    && !type.Name.Equals("SelectionChangeService")
@@ -209,10 +211,10 @@ private void RegisterFactories(IWindsorContainer container, Assembly[] assemblie
         {
             foreach (var assembly in assembliesToRegister)
             {
-                var assemblyClasses = assembly.GetTypes()
-                    .Where(w => _initialSettings.EnableExperimentalFeatures || Attribute.IsDefined(w, typeof(ExperimentalAttribute)));
+                var assemblyTypes = assembly.DefinedTypes
+                    .Where(w => _initialSettings.EnableExperimentalFeatures || !Attribute.IsDefined(w, typeof(ExperimentalAttribute)));
 
-                container.Register(Classes.From(assemblyClasses)
+                container.Register(Types.From(assemblyTypes)
                     .Where(type => type.IsInterface && type.Name.EndsWith("Factory"))
                     .Configure(c => c.AsFactory())
                     .LifestyleSingleton());
@@ -233,10 +235,10 @@ private void RegisterQuickFixes(IWindsorContainer container, Assembly[] assembli
         {
             foreach (var assembly in assembliesToRegister)
             {
-                var assemblyClasses = assembly.GetTypes()
-                    .Where(w => _initialSettings.EnableExperimentalFeatures || Attribute.IsDefined(w, typeof(ExperimentalAttribute)));
+                var assemblyTypes = assembly.DefinedTypes
+                    .Where(w => _initialSettings.EnableExperimentalFeatures || !Attribute.IsDefined(w, typeof(ExperimentalAttribute)));
 
-                container.Register(Classes.From(assemblyClasses)
+                container.Register(Classes.From(assemblyTypes)
                     .BasedOn<IQuickFix>()
                     .WithService.Base()
                     .WithService.Self()
@@ -248,10 +250,10 @@ private void RegisterInspections(IWindsorContainer container, Assembly[] assembl
         {
             foreach (var assembly in assembliesToRegister)
             {
-                var assemblyClasses = assembly.GetTypes()
-                    .Where(w => _initialSettings.EnableExperimentalFeatures || Attribute.IsDefined(w, typeof(ExperimentalAttribute)));
+                var assemblyTypes = assembly.DefinedTypes
+                    .Where(w => _initialSettings.EnableExperimentalFeatures || !Attribute.IsDefined(w, typeof(ExperimentalAttribute)));
 
-                container.Register(Classes.From(assemblyClasses)
+                container.Register(Classes.From(assemblyTypes)
                     .BasedOn<IInspection>()
                     .WithService.Base()
                     .LifestyleTransient());
@@ -262,10 +264,10 @@ private void RegisterParseTreeInspections(IWindsorContainer container, Assembly[
         {
             foreach (var assembly in assembliesToRegister)
             {
-                var assemblyClasses = assembly.GetTypes()
-                    .Where(w => _initialSettings.EnableExperimentalFeatures || Attribute.IsDefined(w, typeof(ExperimentalAttribute)));
+                var assemblyTypes = assembly.DefinedTypes
+                    .Where(w => _initialSettings.EnableExperimentalFeatures || !Attribute.IsDefined(w, typeof(ExperimentalAttribute)));
 
-                container.Register(Classes.From(assemblyClasses)
+                container.Register(Classes.From(assemblyTypes)
                     .BasedOn<IParseTreeInspection>()
                     .WithService.Base()
                     .WithService.Select(new[]{typeof(IInspection)})

Rubberduck.Inspections/Concrete/ConstantNotUsedInspection.cs

@@ -5,15 +5,13 @@
 using Rubberduck.Inspections.Abstract;
 using Rubberduck.Inspections.Results;
 using Rubberduck.Parsing;
-using Rubberduck.Parsing.Common;
 using Rubberduck.Parsing.Inspections.Abstract;
 using Rubberduck.Parsing.Inspections.Resources;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
 
 namespace Rubberduck.Inspections.Concrete
 {
-    [Experimental]
     public sealed class ConstantNotUsedInspection : InspectionBase
     {
         public ConstantNotUsedInspection(RubberduckParserState state)