Skip to content

Commit a0090d6

Browse files
authored
Merge pull request #134 from rubberduck-vba/next
sync with main repo
2 parents 6cccf0c + fe4fe8d commit a0090d6

File tree

7 files changed

+458
-20
lines changed

7 files changed

+458
-20
lines changed

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
![Rubberduck](http://i.stack.imgur.com/vmqXM.png)
1+
<img src="http://i.stack.imgur.com/vmqXM.png" width="320" />
22

3-
| Branch | Build Status |
4-
|------------|--------------|
5-
| **master** | ![master branch build status][masterBuildStatus] |
6-
| **next** | ![next branch build status][nextBuildStatus] |
3+
Branch | Description | Build Status |
4+
|------------|---|--------------|
5+
| **master** | The last released build | ![master branch build status][masterBuildStatus] |
6+
| **next** | The current build (dev) | ![next branch build status][nextBuildStatus] |
77

88
[nextBuildStatus]:https://ci.appveyor.com/api/projects/status/we3pdnkeebo4nlck/branch/next?svg=true
99
[masterBuildStatus]:https://ci.appveyor.com/api/projects/status/we3pdnkeebo4nlck/branch/master?svg=true

RetailCoder.VBE/Inspections/UntypedFunctionUsageInspection.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,9 @@ public UntypedFunctionUsageInspection(RubberduckParserState state)
4343
public override IEnumerable<InspectionResultBase> GetInspectionResults()
4444
{
4545
var declarations = BuiltInDeclarations
46-
// note: these *should* be functions, but somehow they're not defined as such
4746
.Where(item =>
4847
_tokens.Any(token => item.IdentifierName == token || item.IdentifierName == "_B_var_" + token) &&
49-
item.References.Any(reference => _tokens.Contains(reference.IdentifierName)));
48+
item.Scope.StartsWith("VBE7.DLL;"));
5049

5150
return declarations.SelectMany(declaration => declaration.References
5251
.Where(item => _tokens.Contains(item.IdentifierName))

RetailCoder.VBE/Inspections/UntypedFunctionUsageInspectionResult.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ public override void Fix()
6767
var module = Selection.QualifiedName.Component.CodeModule;
6868
var lines = module.Lines[selection.StartLine, selection.LineCount];
6969

70-
var result = lines.Replace(originalInstruction, newInstruction);
70+
var result = lines.Remove(Context.Start.Column, originalInstruction.Length)
71+
.Insert(Context.Start.Column, newInstruction);
7172
module.ReplaceLine(selection.StartLine, result);
7273
}
7374

Rubberduck.Parsing/Rubberduck.Parsing.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@
134134
<Compile Include="Symbols\CommentNode.cs" />
135135
<Compile Include="Symbols\ComParameter.cs" />
136136
<Compile Include="Symbols\DebugDeclarations.cs" />
137+
<Compile Include="Symbols\AliasDeclarations.cs" />
137138
<Compile Include="Symbols\FormEventDeclarations.cs" />
138139
<Compile Include="Symbols\ICustomDelarationLoader.cs" />
139140
<Compile Include="Symbols\Identifier.cs" />

0 commit comments

Comments
 (0)