Skip to content

Commit 9b5eedf

Browse files
committed
Inject dependencies
1 parent 35aac91 commit 9b5eedf

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

Rubberduck.Core/UI/UnitTesting/TestExplorerControl.xaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,15 +438,13 @@
438438
</MenuItem.Icon>
439439
</MenuItem>
440440
<MenuItem Command="{Binding IgnoreTestCommand}"
441-
CommandParameter="{Binding RewritingManager}"
442441
Header="{Resx ResxName=Rubberduck.Resources.UnitTesting.TestExplorer, Key=TestExplorer_TestToggle_Ignore}"
443442
Visibility="{Binding DisplayIgnoreTestLabel, Converter={StaticResource BoolToVisibility}}">
444443
<MenuItem.Icon>
445444
<Image Source="{StaticResource IgnoreTestImage}" />
446445
</MenuItem.Icon>
447446
</MenuItem>
448447
<MenuItem Command="{Binding UnignoreTestCommand}"
449-
CommandParameter="{Binding RewritingManager}"
450448
Header="{Resx ResxName=Rubberduck.Resources.UnitTesting.TestExplorer, Key=TestExplorer_TestToggle_Unignore}"
451449
Visibility="{Binding DisplayUnignoreTestLabel, Converter={StaticResource BoolToVisibility}}">
452450
<MenuItem.Icon>

Rubberduck.Core/UI/UnitTesting/TestExplorerViewModel.cs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ public TestExplorerViewModel(ISelectionService selectionService,
5555
// ReSharper disable once UnusedParameter.Local - left in place because it will likely be needed for app wide font settings, etc.
5656
IConfigurationService<Configuration> configService,
5757
ISettingsFormFactory settingsFormFactory,
58-
IRewritingManager rewritingManager)
58+
IRewritingManager rewritingManager,
59+
IAnnotationUpdater annotationUpdater)
5960
{
6061
_clipboard = clipboard;
6162
_settingsFormFactory = settingsFormFactory;
@@ -74,6 +75,7 @@ public TestExplorerViewModel(ISelectionService selectionService,
7475
UnignoreTestCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteUnignoreTestCommand);
7576

7677
RewritingManager = rewritingManager;
78+
AnnotationUpdater = annotationUpdater;
7779

7880
Model = model;
7981
Model.TestCompleted += HandleTestCompletion;
@@ -233,6 +235,7 @@ private void HandleTestCompletion(object sender, TestCompletedEventArgs e)
233235
}
234236

235237
public IRewritingManager RewritingManager { get; }
238+
public IAnnotationUpdater AnnotationUpdater { get; }
236239

237240
private TestMethod _mousedOverTestMethod => ((TestMethodViewModel)SelectedItem).Method;
238241
public bool DisplayUnignoreTestLabel => SelectedItem != null && _mousedOverTestMethod.IsIgnored;
@@ -371,8 +374,7 @@ private void ExecuteIgnoreTestCommand(object parameter)
371374
{
372375
var rewriteSession = RewritingManager.CheckOutCodePaneSession();
373376

374-
var annotationUpdater = new AnnotationUpdater();
375-
annotationUpdater.AddAnnotation(rewriteSession, _mousedOverTestMethod.Declaration, Parsing.Annotations.AnnotationType.IgnoreTest);
377+
AnnotationUpdater.AddAnnotation(rewriteSession, _mousedOverTestMethod.Declaration, Parsing.Annotations.AnnotationType.IgnoreTest);
376378

377379
rewriteSession.TryRewrite();
378380
}
@@ -383,13 +385,10 @@ private void ExecuteUnignoreTestCommand(object parameter)
383385
var ignoreTestAnnotations = _mousedOverTestMethod.Declaration.Annotations
384386
.Where(iannotations => iannotations.AnnotationType == Parsing.Annotations.AnnotationType.IgnoreTest);
385387

386-
var annotationUpdater = new AnnotationUpdater();
387-
388388
foreach (var ignoreTestAnnotation in ignoreTestAnnotations)
389389
{
390-
annotationUpdater.RemoveAnnotation(rewriteSession, ignoreTestAnnotation);
390+
AnnotationUpdater.RemoveAnnotation(rewriteSession, ignoreTestAnnotation);
391391
}
392-
393392

394393
rewriteSession.TryRewrite();
395394
}

RubberduckTests/UnitTesting/MockedTestExplorer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public MockedTestExplorer(MockedTestExplorerModel model)
1414
Vbe = model.Engine.Vbe.Object;
1515
State = model.Engine.ParserState;
1616
Model = model.Model;
17-
ViewModel = new TestExplorerViewModel(null, Model, ClipboardWriter.Object, null, null, null);
17+
ViewModel = new TestExplorerViewModel(null, Model, ClipboardWriter.Object, null, null, null, null);
1818
}
1919

2020
public RubberduckParserState State { get; set; }

0 commit comments

Comments
 (0)