Change exceptions raised, addresses CA1065.

Author: comintern

Rubberduck.Core/UI/Inspections/AggregateInspectionResult.cs

@@ -27,7 +27,7 @@ public AggregateInspectionResult(IInspectionResult firstResult, int count)
 
         public ParserRuleContext Context => _result.Context;
 
-        public dynamic Properties => throw new NotImplementedException();
+        public dynamic Properties => throw new InvalidOperationException();
 
         public int CompareTo(IInspectionResult other)
         {

Rubberduck.UnitTesting/ComClientHelpers/PermissiveObjectComparer.cs

@@ -56,6 +56,7 @@ public class PermissiveObjectComparer : IEqualityComparer<object>
         /// </summary>
         /// <param name="obj"></param>
         /// <returns>NotSupportedException</returns>
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1065")]     // see comment below.
         public int GetHashCode(object obj)
         {
             //This is intentional to "discourage" any use of the comparer that relies on GetHashCode().

Rubberduck.VBEEditor/ComManagement/TypeLibs/TypeLibs.cs

@@ -252,7 +252,7 @@ public bool CompileProject()
         {
             if (!HasVBEExtensions)
             {
-                throw new ArgumentException("This TypeLib does not represent a VBE project, so we cannot compile it");
+                throw new InvalidOperationException("This TypeLib does not represent a VBE project, so we cannot compile it");
             }
 
             try
@@ -266,7 +266,7 @@ public bool CompileProject()
                 if (e.HResult != (int)KnownComHResults.E_VBA_COMPILEERROR)
                 {
                     // this is for debug purposes, to see if the compiler ever returns other errors on failure
-                    throw new ArgumentException("Unrecognised VBE compiler error: \n" + e.ToString());
+                    throw new InvalidOperationException("Unrecognised VBE compiler error: \n" + e.ToString());
                 }
 #endif
                 return false;
@@ -283,7 +283,7 @@ public string ConditionalCompilationArgumentsRaw
             {
                 if (!HasVBEExtensions)
                 {
-                    throw new ArgumentException("This ITypeLib is not hosted by the VBE, so does not support ConditionalCompilationArguments");
+                    throw new InvalidOperationException("This ITypeLib is not hosted by the VBE, so does not support ConditionalCompilationArguments");
                 }
 
                 return target_IVBEProject.GetConditionalCompilationArgs();
@@ -293,7 +293,7 @@ public string ConditionalCompilationArgumentsRaw
             {
                 if (!HasVBEExtensions)
                 {
-                    throw new ArgumentException("This ITypeLib is not hosted by the VBE, so does not support ConditionalCompilationArguments");
+                    throw new InvalidOperationException("This ITypeLib is not hosted by the VBE, so does not support ConditionalCompilationArguments");
                 }
 
                 target_IVBEProject.SetConditionalCompilationArgs(value);
@@ -310,7 +310,7 @@ public Dictionary<string, short> ConditionalCompilationArguments
             {
                 if (!HasVBEExtensions)
                 {
-                    throw new ArgumentException("This ITypeLib is not hosted by the VBE, so does not support ConditionalCompilationArguments");
+                    throw new InvalidOperationException("This ITypeLib is not hosted by the VBE, so does not support ConditionalCompilationArguments");
                 }
 
                 string args = target_IVBEProject.GetConditionalCompilationArgs();
@@ -330,7 +330,7 @@ public Dictionary<string, short> ConditionalCompilationArguments
             {
                 if (!HasVBEExtensions)
                 {
-                    throw new ArgumentException("This ITypeLib is not hosted by the VBE, so does not support ConditionalCompilationArguments");
+                    throw new InvalidOperationException("This ITypeLib is not hosted by the VBE, so does not support ConditionalCompilationArguments");
                 }
 
                 var rawArgsString = string.Join(" : ", value.Select(x => x.Key + " = " + x.Value));