Add validation to the NumberPicker to prevent values from being set lower/higher than a specific value.

Author: Hosch250

RetailCoder.VBE/Rubberduck.csproj

@@ -218,6 +218,9 @@
     <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
     <WarningLevel>4</WarningLevel>
   </PropertyGroup>
+  <PropertyGroup>
+    <StartupObject />
+  </PropertyGroup>
   <ItemGroup>
     <Reference Include="Antlr4.Runtime.net45">
       <HintPath>..\packages\Antlr4.Runtime.4.3.0\lib\net45\Antlr4.Runtime.net45.dll</HintPath>

RetailCoder.VBE/UI/Controls/NumberPicker.xaml

@@ -8,7 +8,7 @@
              Name="Root">
     <Grid>
         <StackPanel Orientation="Horizontal">
-            <TextBox Margin="5,5,0,5" Height="20" Width="50" Text="{Binding ElementName=Root, Path=NumValue, Mode=TwoWay, StringFormat=\{0:D\}, UpdateSourceTrigger=PropertyChanged}" VerticalAlignment="Top" VerticalContentAlignment="Center" />
+            <TextBox Margin="5,5,0,5" Height="20" Width="50" Text="{Binding ElementName=Root, Path=NumValue, Mode=TwoWay, StringFormat=\{0:D\}, UpdateSourceTrigger=PropertyChanged, ValidatesOnDataErrors=True}" VerticalAlignment="Top" VerticalContentAlignment="Center" />
             <StackPanel Margin="0,5" >
                 <Button Height="10" Width="20" Click="cmdUp_Click">
                     <TextBlock Text="˄" FontSize="10" Margin="0,-4,0,0"/>

RetailCoder.VBE/UI/Controls/NumberPicker.xaml.cs

@@ -1,12 +1,13 @@
-using System.Windows;
+using System.ComponentModel;
+using System.Windows;
 
 // credit to http://stackoverflow.com/a/2752538
 namespace Rubberduck.UI.Controls
 {
     /// <summary>
     /// Interaction logic for NumberPicker.xaml
     /// </summary>
-    public partial class NumberPicker
+    public partial class NumberPicker : IDataErrorInfo
     {
         public static readonly DependencyProperty NumValueProperty =
             DependencyProperty.Register("NumValue", typeof(int), typeof(NumberPicker), new UIPropertyMetadata(null));
@@ -24,6 +25,20 @@ public int NumValue
             }
         }
 
+        private int _minNumber = int.MinValue;
+        public int MinNumber
+        {
+            get { return _minNumber; }
+            set { _minNumber = value; }
+        }
+
+        private int _maxNumber = int.MaxValue;
+        public int MaxNumber
+        {
+            get { return _maxNumber; }
+            set { _maxNumber = value; }
+        }
+
         public NumberPicker()
         {
             InitializeComponent();
@@ -38,5 +53,25 @@ private void cmdDown_Click(object sender, RoutedEventArgs e)
         {
             NumValue--;
         }
+
+        public string this[string columnName]
+        {
+            get
+            {
+                if (columnName != "NumValue")
+                {
+                    return string.Empty;
+                }
+
+                if (NumValue < MinNumber || NumValue > MaxNumber)
+                {
+                    return "Invalid Selection";
+                }
+
+                return string.Empty;
+            }
+        }
+
+        public string Error { get; private set; }
     }
 }

RetailCoder.VBE/UI/Settings/GeneralSettings.xaml

@@ -91,6 +91,7 @@
                 <controls:NumberPicker Margin="0,-6,0,0"
                                        IsEnabled="{Binding ElementName=AutoSaveButton, Path=IsChecked}"
                                        NumValue="{Binding AutoSavePeriod, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
+                                       MinNumber="1"
                                        HorizontalAlignment="Left" />
             </StackPanel>
 

RetailCoder.VBE/UI/Settings/IndenterSettings.xaml

@@ -78,7 +78,8 @@
                             <controls:NumberPicker Margin="0,-6,0,0"
                                                    IsEnabled="{Binding ElementName=AlignDimColumn, Path=IsChecked}"
                                                    NumValue="{Binding AlignDimColumn, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
-                                                   HorizontalAlignment="Left" />
+                                                   HorizontalAlignment="Left"
+                                                   MinNumber="0"/>
                         </StackPanel>
                         <Label Content="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=IndenterSettings_SpecialOptionsLabel}"
                                FontWeight="SemiBold" />
@@ -123,7 +124,8 @@
                                        Margin="5,0,0,5"
                                        HorizontalAlignment="Left" />
                             <controls:NumberPicker Margin="0,-6,0,0"
-                                                   NumValue="{Binding IndentSpaces, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" />
+                                                   NumValue="{Binding IndentSpaces, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
+                                                   MinNumber="0"/>
                         </StackPanel>
                         <Label Content="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=IndenterSettings_EnableOptionsLabel}"
                                FontWeight="SemiBold" />
@@ -146,7 +148,8 @@
                     <controls:NumberPicker Margin="0,-4,0,0"
                                            NumValue="{Binding EndOfLineCommentColumnSpaceAlignment, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
                                            Visibility="{Binding EndOfLineCommentStyle, Converter={StaticResource EndOfLineCommentStyleToVisibility}}"
-                                           HorizontalAlignment="Left" />
+                                           HorizontalAlignment="Left"
+                                           MinNumber="0" />
                 </StackPanel>
             </StackPanel>
         </ScrollViewer>