Skip to content

Commit 96626f7

Browse files
committed
fixed FunctionReturnValueNotUsed firing on Sub procedures
1 parent 462665e commit 96626f7

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

RetailCoder.VBE/Inspections/FunctionReturnValueNotUsedInspection.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,14 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
3232
var nonInterfaceFunctions = functions.Except(interfaceMembers.Union(interfaceImplementationMembers));
3333
var nonInterfaceIssues = GetNonInterfaceIssues(nonInterfaceFunctions);
3434
return interfaceMemberIssues.Union(nonInterfaceIssues);
35-
//// Temporarily disabled until fix for lack of context because of new resolver is found...
36-
//return new List<InspectionResultBase>();
3735
}
3836

3937
private IEnumerable<FunctionReturnValueNotUsedInspectionResult> GetInterfaceMemberIssues(IEnumerable<Declaration> interfaceMembers)
4038
{
4139
return from interfaceMember in interfaceMembers
4240
let implementationMembers =
4341
UserDeclarations.FindInterfaceImplementationMembers(interfaceMember.IdentifierName).ToList()
44-
where
42+
where interfaceMember.DeclarationType == DeclarationType.Function &&
4543
!IsReturnValueUsed(interfaceMember) &&
4644
implementationMembers.All(member => !IsReturnValueUsed(member))
4745
let implementationMemberIssues =
@@ -58,7 +56,7 @@ private IEnumerable<FunctionReturnValueNotUsedInspectionResult> GetInterfaceMemb
5856

5957
private IEnumerable<FunctionReturnValueNotUsedInspectionResult> GetNonInterfaceIssues(IEnumerable<Declaration> nonInterfaceFunctions)
6058
{
61-
var returnValueNotUsedFunctions = nonInterfaceFunctions.Where(function => !IsReturnValueUsed(function));
59+
var returnValueNotUsedFunctions = nonInterfaceFunctions.Where(function => function.DeclarationType == DeclarationType.Function && !IsReturnValueUsed(function));
6260
var nonInterfaceIssues = returnValueNotUsedFunctions
6361
.Select(function =>
6462
new FunctionReturnValueNotUsedInspectionResult(

0 commit comments

Comments
 (0)