Skip to content

Commit 961719f

Browse files
committed
Remove tests requiring us to load an external library
1 parent 7123cac commit 961719f

File tree

4 files changed

+0
-122
lines changed

4 files changed

+0
-122
lines changed

RubberduckTests/Inspections/ImplicitByRefParameterInspectionTests.cs

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -173,36 +173,6 @@ Sub IClass1_Foo(arg1 As Integer)
173173
Assert.AreEqual(1, inspectionResults.Count());
174174
}
175175

176-
[TestMethod]
177-
[TestCategory("Inspections")]
178-
public void ImplicitByRefParameter_DoesNotReturnResult_BuiltInEvent()
179-
{
180-
//Input
181-
const string inputCode =
182-
@"Private Sub UserForm_Zoom(Percent As Integer)
183-
184-
End Sub";
185-
186-
//Arrange
187-
var builder = new MockVbeBuilder();
188-
var project = builder.ProjectBuilder("TestProject1", vbext_ProjectProtection.vbext_pp_none)
189-
.AddComponent("Class1", vbext_ComponentType.vbext_ct_MSForm, inputCode)
190-
.Build();
191-
var vbe = builder.AddProject(project).Build();
192-
193-
var mockHost = new Mock<IHostApplication>();
194-
mockHost.SetupAllProperties();
195-
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
196-
197-
parser.Parse();
198-
if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
199-
200-
var inspection = new ImplicitByRefParameterInspection(parser.State);
201-
var inspectionResults = inspection.GetInspectionResults();
202-
203-
Assert.AreEqual(0, inspectionResults.Count());
204-
}
205-
206176
[TestMethod]
207177
[TestCategory("Inspections")]
208178
public void ImplicitByRefParameter_QuickFixWorks_PassByRef()

RubberduckTests/Inspections/ParameterNotUsedInspectionTests.cs

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -92,32 +92,6 @@ public void ParameterUsed_DoesNotReturnResult()
9292
Assert.AreEqual(0, inspectionResults.Count());
9393
}
9494

95-
[TestMethod]
96-
[TestCategory("Inspections")]
97-
public void ParameterUsed_BuiltInEventHandlerParameter_DoesNotReturnResult()
98-
{
99-
const string inputCode =
100-
@"Private Sub UserForm_BeforeDropOrPaste(ByVal Cancel As MSForms.ReturnBoolean, ByVal Control As MSForms.Control, ByVal Action As MSForms.fmAction, ByVal Data As MSForms.DataObject, ByVal X As Single, ByVal Y As Single, ByVal Effect As MSForms.ReturnEffect, ByVal Shift As Integer)
101-
102-
End Sub";
103-
104-
//Arrange
105-
var builder = new MockVbeBuilder();
106-
VBComponent component;
107-
var vbe = builder.BuildFromSingleModule(inputCode, vbext_ComponentType.vbext_ct_MSForm, out component, new Rubberduck.VBEditor.Selection());
108-
var mockHost = new Mock<IHostApplication>();
109-
mockHost.SetupAllProperties();
110-
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
111-
112-
parser.Parse();
113-
if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
114-
115-
var inspection = new ParameterNotUsedInspection(vbe.Object, parser.State, null);
116-
var inspectionResults = inspection.GetInspectionResults();
117-
118-
Assert.AreEqual(0, inspectionResults.Count());
119-
}
120-
12195
[TestMethod]
12296
[TestCategory("Inspections")]
12397
public void ParameterNotUsed_ReturnsResult_SomeParamsUsed()

RubberduckTests/Inspections/ProcedureNotUsedInspectionTests.cs

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -194,36 +194,6 @@ Private Sub abc_Foo(ByVal arg1 As Integer, ByVal arg2 As String)
194194
Assert.AreEqual(0, inspectionResults.Count());
195195
}
196196

197-
[TestMethod]
198-
[TestCategory("Inspections")]
199-
public void ProcedureNotUsed_DoesNotReturnResult_BuiltInEventImplementation()
200-
{
201-
//Input
202-
const string inputCode =
203-
@"Private Sub UserForm_BeforeDropOrPaste(ByVal Cancel As MSForms.ReturnBoolean, ByVal Control As MSForms.Control, ByVal Action As MSForms.fmAction, ByVal Data As MSForms.DataObject, ByVal X As Single, ByVal Y As Single, ByVal Effect As MSForms.ReturnEffect, ByVal Shift As Integer)
204-
205-
End Sub";
206-
207-
//Arrange
208-
var builder = new MockVbeBuilder();
209-
var project = builder.ProjectBuilder("TestProject1", vbext_ProjectProtection.vbext_pp_none)
210-
.AddComponent("Form", vbext_ComponentType.vbext_ct_MSForm, inputCode)
211-
.Build();
212-
var vbe = builder.AddProject(project).Build();
213-
214-
var mockHost = new Mock<IHostApplication>();
215-
mockHost.SetupAllProperties();
216-
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
217-
218-
parser.Parse();
219-
if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
220-
221-
var inspection = new ProcedureNotUsedInspection(parser.State);
222-
var inspectionResults = inspection.GetInspectionResults();
223-
224-
Assert.AreEqual(0, inspectionResults.Count());
225-
}
226-
227197
[TestMethod]
228198
[TestCategory("Inspections")]
229199
public void ProcedureNotUsed_NoResultForClassInitialize()

RubberduckTests/Inspections/ProcedureShouldBeFunctionInspectionTests.cs

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -290,42 +290,6 @@ Private Sub abc_Foo(ByRef arg1 As Integer)
290290
Assert.AreEqual(0, inspectionResults.Count());
291291
}
292292

293-
[TestMethod]
294-
[TestCategory("Inspections")]
295-
public void ProcedureShouldBeFunction_DoesNotReturnResult_BuiltInEventImplementation()
296-
{
297-
//Input
298-
const string inputCode =
299-
@"Private Sub UserForm_Zoom(Percent As Integer)
300-
301-
End Sub";
302-
303-
//Arrange
304-
var settings = new Mock<IGeneralConfigService>();
305-
var config = GetTestConfig();
306-
settings.Setup(x => x.LoadConfiguration()).Returns(config);
307-
308-
var builder = new MockVbeBuilder();
309-
var project = builder.ProjectBuilder("TestProject1", vbext_ProjectProtection.vbext_pp_none)
310-
.AddComponent("Class1", vbext_ComponentType.vbext_ct_MSForm, inputCode)
311-
.Build();
312-
var vbe = builder.AddProject(project).Build();
313-
314-
var mockHost = new Mock<IHostApplication>();
315-
mockHost.SetupAllProperties();
316-
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
317-
318-
parser.Parse();
319-
if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
320-
321-
var inspection = new ProcedureCanBeWrittenAsFunctionInspection(parser.State);
322-
var inspector = new Inspector(settings.Object, new IInspection[] { inspection });
323-
324-
var inspectionResults = inspector.FindIssuesAsync(parser.State, CancellationToken.None).Result;
325-
326-
Assert.AreEqual(0, inspectionResults.Count());
327-
}
328-
329293
[TestMethod]
330294
[TestCategory("Inspections")]
331295
public void ProcedureShouldBeFunction_QuickFixWorks()

0 commit comments

Comments
 (0)