Removed caching of code modules from ProjectsRepository because it caused bugs on the VBE side.

Author: MDoerner

Rubberduck.VBEEditor/ComManagement/IProjectsProvider.cs

@@ -13,8 +13,5 @@ public interface IProjectsProvider : IDisposable
         IEnumerable<(QualifiedModuleName QualifiedModuleName, IVBComponent Component)> Components();
         IEnumerable<(QualifiedModuleName QualifiedModuleName, IVBComponent Component)> Components(string projectId);
         IVBComponent Component(QualifiedModuleName qualifiedModuleName);
-        IEnumerable<(QualifiedModuleName QualifiedModuleName, ICodeModule CodeModule)> CodeModules();
-        IEnumerable<(QualifiedModuleName QualifiedModuleName, ICodeModule CodeModule)> CodeModules(string projectId);
-        ICodeModule CodeModule(QualifiedModuleName qualifiedModuleName);
     }
 }

Rubberduck.VBEEditor/ComManagement/ProjectsRepository.cs

@@ -14,7 +14,6 @@ public class ProjectsRepository : IProjectsRepository
         private readonly IDictionary<string, IVBProject> _projects = new Dictionary<string, IVBProject>();
         private readonly IDictionary<string, IVBComponents> _componentsCollections = new Dictionary<string, IVBComponents>();
         private readonly IDictionary<QualifiedModuleName, IVBComponent> _components = new Dictionary<QualifiedModuleName, IVBComponent>();
-        private readonly IDictionary<QualifiedModuleName, ICodeModule> _codeModules = new Dictionary<QualifiedModuleName, ICodeModule>();
 
         private readonly ReaderWriterLockSlim _refreshProtectionLock = new ReaderWriterLockSlim(LockRecursionPolicy.NoRecursion);
 
@@ -75,7 +74,6 @@ private void LoadComponents(IVBComponents componentsCollection)
             {
                 var qmn = component.QualifiedModuleName;
                 _components.Add(qmn, component);
-                _codeModules.Add(qmn, component.CodeModule);
             }
         }
 
@@ -114,14 +112,12 @@ private void RefreshCollections()
             var projects = ClearComWrapperDictionary(_projects);
             var componentCollections = ClearComWrapperDictionary(_componentsCollections);
             var components = ClearComWrapperDictionary(_components);
-            var codeModules = ClearComWrapperDictionary(_codeModules);
 
             LoadCollections();
 
             DisposeWrapperEnumerable(projects);
             DisposeWrapperEnumerable(componentCollections);
             DisposeWrapperEnumerable(components);
-            DisposeWrapperEnumerable(codeModules);
         }
 
         private IEnumerable<TWrapper> ClearComWrapperDictionary<TKey, TWrapper>(IDictionary<TKey, TWrapper> dictionary)
@@ -150,20 +146,17 @@ private void RefreshCollections(string projectId)
 
             var componentsCollection = _componentsCollections[projectId];
             var components = _components.Where(kvp => kvp.Key.ProjectId.Equals(projectId)).ToList();
-            var codeModules = _codeModules.Where(kvp => kvp.Key.ProjectId.Equals(projectId)).ToList();
 
             foreach (var qmn in components.Select(kvp => kvp.Key))
             {
                 _components.Remove(qmn);
-                _codeModules.Remove(qmn);
             }
 
             _componentsCollections[projectId] = project.VBComponents;
             LoadComponents(_componentsCollections[projectId]);
 
             componentsCollection.Dispose();
             DisposeWrapperEnumerable(components.Select(kvp => kvp.Value));
-            DisposeWrapperEnumerable(codeModules.Select(kvp => kvp.Value));
         }
 
         public void Refresh(string projectId)
@@ -242,24 +235,6 @@ public IVBComponent Component(QualifiedModuleName qualifiedModuleName)
             return EvaluateWithinReadLock(() => _components.TryGetValue(qualifiedModuleName, out var component) ? component : null);
         }
 
-        public IEnumerable<(QualifiedModuleName QualifiedModuleName, ICodeModule CodeModule)> CodeModules()
-        {
-            return EvaluateWithinReadLock(() => _codeModules.Select(kvp => (kvp.Key, kvp.Value)).ToList()) ?? new List<(QualifiedModuleName, ICodeModule)>();
-        }
-
-        public IEnumerable<(QualifiedModuleName QualifiedModuleName, ICodeModule CodeModule)> CodeModules(string projectId)
-        {
-            return EvaluateWithinReadLock(() => _codeModules.Where(kvp => kvp.Key.ProjectId.Equals(projectId))
-                       .Select(kvp => (kvp.Key, kvp.Value))
-                       .ToList())
-                   ?? new List<(QualifiedModuleName, ICodeModule)>();
-        }
-
-        public ICodeModule CodeModule(QualifiedModuleName qualifiedModuleName)
-        {
-            return EvaluateWithinReadLock(() => _codeModules.TryGetValue(qualifiedModuleName, out var codeModule) ? codeModule : null);
-        }
-
         private bool _disposed;
         public void Dispose()
         {
@@ -283,12 +258,10 @@ private void ClearCollections()
             var projects = ClearComWrapperDictionary(_projects);
             var componentCollections = ClearComWrapperDictionary(_componentsCollections);
             var components = ClearComWrapperDictionary(_components);
-            var codeModules = ClearComWrapperDictionary(_codeModules);
 
             DisposeWrapperEnumerable(projects);
             DisposeWrapperEnumerable(componentCollections);
             DisposeWrapperEnumerable(components);
-            DisposeWrapperEnumerable(codeModules);
         }
     }
 }