Immediately fail the resolution of a with member access without a with expression

This prevents an otherwise guaranteed NRE in the MemberAccessBinding and lets us resolve everything else instead of outright stopping resolution because of the unexpected NRE.

Author: MDoerner

Rubberduck.Parsing/Binding/Bindings/LetCoercionDefaultBinding.cs

@@ -114,7 +114,7 @@ private static IBoundExpression ResolveViaDefaultMember(IBoundExpression wrapped
                 && defaultMember.DeclarationType == DeclarationType.PropertyLet
                 && IsCompatibleWithOneNonObjectParameter(parameters))
             {
-                //This is a Let assignment. So, finding a Property Let with one non object paramter means we are done.
+                //This is a Let assignment. So, finding a Property Let with one non object parameter means we are done.
                 return new LetCoercionDefaultMemberAccessExpression(defaultMember, defaultMemberClassification, expression, wrappedExpression, recursionDepth, containedExpression);
             }
 

Rubberduck.Parsing/Binding/Bindings/NewTypeBinding.cs

@@ -1,29 +1,16 @@
 using Antlr4.Runtime;
-using Rubberduck.Parsing.Symbols;
-using Rubberduck.Parsing.VBA.DeclarationCaching;
 
 namespace Rubberduck.Parsing.Binding
 {
     public sealed class NewTypeBinding : IExpressionBinding
     {
-        private readonly DeclarationFinder _declarationFinder;
-        private readonly Declaration _project;
-        private readonly Declaration _module;
-        private readonly Declaration _parent;
         private readonly ParserRuleContext _expression;
         private readonly IExpressionBinding _typeExpressionBinding;
 
         public NewTypeBinding(
-            DeclarationFinder declarationFinder,
-            Declaration module,
-            Declaration parent,
             ParserRuleContext expression,
             IExpressionBinding typeExpressionBinding)
         {
-            _declarationFinder = declarationFinder;
-            _project = module.ParentDeclaration;
-            _module = module;
-            _parent = parent;
             _expression = expression;
             _typeExpressionBinding = typeExpressionBinding;
         }

Rubberduck.Parsing/Binding/DefaultBindingContext.cs

@@ -198,7 +198,7 @@ private IExpressionBinding Visit(Declaration module, Declaration parent, VBAPars
             {
                 return null;
             }
-            return new NewTypeBinding(_declarationFinder, module, parent, expression, typeExpressionBinding);
+            return new NewTypeBinding(expression, typeExpressionBinding);
         }
 
         private IExpressionBinding Visit(Declaration module, Declaration parent, VBAParser.MarkedFileNumberExprContext expression, IBoundExpression withBlockVariable)
@@ -442,6 +442,10 @@ declared type of String and a value equal to the name value of <unrestricted-nam
 
         private IExpressionBinding Visit(Declaration module, Declaration parent, VBAParser.WithMemberAccessExprContext expression, IBoundExpression withBlockVariable, StatementResolutionContext statementContext)
         {
+            if (withBlockVariable == null)
+            {
+                withBlockVariable = new ResolutionFailedExpression(expression);
+            }
             return new MemberAccessDefaultBinding(_declarationFinder, Declaration.GetProjectParent(parent), module, parent, expression, withBlockVariable, expression.unrestrictedIdentifier().GetText(), statementContext, expression.unrestrictedIdentifier());
         }
 

Rubberduck.Parsing/VBA/DeclarationCaching/DeclarationFinder.cs

@@ -1002,7 +1002,8 @@ public void AddUnboundContext(Declaration parentDeclaration, VBAParser.LExpressi
         {
 
             //The only forms we care about right now are MemberAccessExprContext or WithMemberAccessExprContext.
-            if (!(context is VBAParser.MemberAccessExprContext) && !(context is VBAParser.WithMemberAccessExprContext))
+            //For WithMemberAccessExpressions we can only save an unbout member if the withExpression is not null.
+            if (!(context is VBAParser.MemberAccessExprContext) && !(context is VBAParser.WithMemberAccessExprContext && withExpression != null))
             {
                 return;
             }

Rubberduck.Parsing/VBA/ReferenceManagement/IdentifierReferenceResolver.cs

@@ -82,7 +82,6 @@ public void EnterWithBlock(VBAParser.WithStmtContext context)
                 false);
             _failedResolutionVisitor.CollectUnresolved(boundExpression, _currentParent, withExpression);
             _boundExpressionVisitor.AddIdentifierReferences(boundExpression, _qualifiedModuleName, _currentScope, _currentParent);
-            // note: pushes null if unresolved
             _withBlockExpressions.Push(boundExpression);
         }