Merge pull request #2158 from Hosch250/Issue2130

Fix cache bug causing KeyNotFoundInDictionary exception

Author: Hosch250

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -637,8 +637,6 @@ private void ClearStateCache(string projectId, bool notifyStateChanged = false)
         {
             try
             {
-                var qualifiedModuleName = new QualifiedModuleName();
-
                 foreach (var moduleState in _moduleStates)
                 {
                     if (moduleState.Key.ProjectId == projectId && moduleState.Key.Component != null)
@@ -651,15 +649,14 @@ private void ClearStateCache(string projectId, bool notifyStateChanged = false)
                     else if (moduleState.Key.ProjectId == projectId && moduleState.Key.Component == null)
                     {
                         // store project module name
-                        qualifiedModuleName = moduleState.Key;
+                        var qualifiedModuleName = moduleState.Key;
+                        ModuleState state;
+                        if (_moduleStates.TryRemove(qualifiedModuleName, out state))
+                        {
+                            state.Dispose();
+                        }
                     }
                 }
-
-                ModuleState state;
-                if (_moduleStates.TryRemove(qualifiedModuleName, out state))
-                {
-                    state.Dispose();
-                }
             }
             catch (COMException)
             {