keyhook now handled same as mouse hook

Author: retailcoder

RetailCoder.VBE/App.cs

@@ -85,7 +85,7 @@ public App(VBE vbe, IMessageBox messageBox,
             _hookActions = new Dictionary<Type, Action>
             {
                 { typeof(MouseHook), HandleMouseMessage },
-                //{ typeof(KeyboardHook), HandleKeyboardMessage },
+                { typeof(KeyboardHook), HandleKeyboardMessage },
             };
 
 
@@ -104,18 +104,18 @@ private void _hooks_MessageReceived(object sender, HookEventArgs e)
 
         private void HandleMouseMessage()
         {
-            _stateBar.SetSelectionText(_parser.State.FindSelectedDeclaration(_vbe.ActiveCodePane));
-            _appMenus.EvaluateCanExecute(_parser.State);
+            RefreshSelection();
         }
 
         private void HandleKeyboardMessage()
         {
-            var pane = _vbe.ActiveCodePane;
-            if (pane == null)
-            {
-                return;
-            }
-            _parser.State.OnParseRequested(this, pane.CodeModule.Parent);
+            RefreshSelection();
+        }
+
+        private void RefreshSelection()
+        {
+            _stateBar.SetSelectionText(_parser.State.FindSelectedDeclaration(_vbe.ActiveCodePane));
+            _appMenus.EvaluateCanExecute(_parser.State);
         }
 
         private void _configService_SettingsChanged(object sender, EventArgs e)

RetailCoder.VBE/Common/KeyboardHook.cs

@@ -1,6 +1,10 @@
 using System;
+using System.Collections.Generic;
 using System.ComponentModel;
 using System.Diagnostics;
+using System.Linq;
+using System.Runtime.InteropServices;
+using System.Windows.Forms;
 using Microsoft.Vbe.Interop;
 using Rubberduck.Common.WinAPI;
 
@@ -19,13 +23,29 @@ public KeyboardHook(VBE vbe)
             _callback = HookCallback;
         }
 
+        // keys that don't modify anything in the code pane but the current selection
+        private static readonly IReadOnlyList<Keys> NavigationKeys = new[]
+        {
+            Keys.Down,
+            Keys.Up,
+            Keys.Left,
+            Keys.Right,
+            Keys.PageDown,
+            Keys.PageUp,
+            Keys.Home,
+            Keys.End,
+        };
+
         private int _lastLineIndex;
         private IntPtr HookCallback(int nCode, IntPtr wParam, IntPtr lParam)
         {
             try
             {
                 var pane = _vbe.ActiveCodePane;
-                if (User32.IsVbeWindowActive((IntPtr)_vbe.MainWindow.HWnd) && pane != null && (WM)wParam == WM.KEYUP)
+                if ((WM)wParam == WM.KEYDOWN
+                    && pane != null
+                    && NavigationKeys.Contains((Keys)Marshal.ReadInt32(lParam)) 
+                    && User32.IsVbeWindowActive((IntPtr)_vbe.MainWindow.HWnd))
                 {
                     int startLine;
                     int endLine;
@@ -36,11 +56,9 @@ private IntPtr HookCallback(int nCode, IntPtr wParam, IntPtr lParam)
                     pane.GetSelection(out startLine, out startColumn, out endLine, out endColumn);
                     if (startLine != _lastLineIndex)
                     {
-                        // if the current line has changed, let the KEYDOWN be written to the IDE, and notify on KEYUP:
                         _lastLineIndex = startLine;
                         if (nCode >= 0)
                         {
-                            //var key = (Keys)Marshal.ReadInt32(lParam);
                             OnMessageReceived();
                         }
                     }

RetailCoder.VBE/Common/RubberduckHooks.cs

@@ -45,7 +45,7 @@ public void HookHotkeys()
             var config = _config.LoadConfiguration();
             var settings = config.UserSettings.GeneralSettings.HotkeySettings;
 
-            //AddHook(new KeyboardHook(_vbe));
+            AddHook(new KeyboardHook(_vbe));
             AddHook(new MouseHook(_vbe));
             foreach (var hotkey in settings.Where(hotkey => hotkey.IsEnabled))
             {

Rubberduck.Parsing/VBA/RubberduckParser.cs

@@ -279,15 +279,18 @@ public void Resolve(CancellationToken token)
 
         private void ResolveInternal(CancellationToken token)
         {
-            if (!_state.HasAllParseTrees)
+            var components = _state.Projects
+                .Where(project => project.Protection == vbext_ProjectProtection.vbext_pp_none)
+                .SelectMany(p => p.VBComponents.Cast<VBComponent>()).ToList();
+            if (!_state.HasAllParseTrees(components))
             {
                 return;
             }
 
             foreach (var kvp in _state.ParseTrees)
             {
                 var qualifiedName = kvp.Key;
-                if (_force || _state.IsModified(qualifiedName))
+                if (/*_force || _state.IsModified(qualifiedName)*/ true)
                 {
                     Debug.WriteLine(string.Format("Module '{0}' is new or was modified since last parse. Walking parse tree for declarations...", kvp.Key.ComponentName));
                     // modified module; walk parse tree and re-acquire all declarations

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -415,7 +415,16 @@ public IParseTree GetParseTree(VBComponent component)
 
         public IEnumerable<KeyValuePair<QualifiedModuleName, IParseTree>> ParseTrees { get { return _parseTrees; } }
 
-        public bool HasAllParseTrees { get { return _moduleStates.Count == _parseTrees.Count; } }
+        public bool HasAllParseTrees(IReadOnlyList<VBComponent> expected)
+        {
+            var expectedModules = expected.Select(module => new QualifiedModuleName(module));
+            foreach (var module in _moduleStates.Keys.Where(item => !expectedModules.Contains(item)))
+            {
+                ClearDeclarations(module.Component);
+            }
+
+            return _parseTrees.Count == expected.Count;
+        }        
 
         public TokenStreamRewriter GetRewriter(VBComponent component)
         {