Prevent Equals from having cast failure exception

Hosch250 · Hosch250 · commit 9189b7b19ddd · 2015-06-19T12:20:25.000-05:00
diff --git a/RetailCoder.VBE/Settings/ToDoMarkers.cs b/RetailCoder.VBE/Settings/ToDoMarkers.cs
@@ -59,7 +59,9 @@ public override string ToString()
 
         public override bool Equals(object obj)
         {
-            var other = (ToDoMarker)obj;
+            var other = obj as ToDoMarker;
+
+            if (other == null) { return false; }
 
             // no need to check PriorityLabel as it soley relies on Priority - if one is wrong, the other has to be too
             return Text == other.Text &&

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,9 @@ public override string ToString()`
`59`	`59`
`60`	`60`	`public override bool Equals(object obj)`
`61`	`61`	`{`
`62`		`- var other = (ToDoMarker)obj;`
	`62`	`+ var other = obj as ToDoMarker;`
	`63`	`+`
	`64`	`+ if (other == null) { return false; }`
`63`	`65`
`64`	`66`	`// no need to check PriorityLabel as it soley relies on Priority - if one is wrong, the other has to be too`
`65`	`67`	`return Text == other.Text &&`