Merge pull request #2441 from comintern/next

Add test for borked resolver, fix #2440

Author: retailcoder

RetailCoder.VBE/API/ParserState.cs

@@ -9,8 +9,6 @@
 using Rubberduck.Parsing.Preprocessing;
 using System.Globalization;
 using Rubberduck.Parsing.Symbols;
-using Rubberduck.VBEditor;
-using Rubberduck.VBEditor.Events;
 using Rubberduck.VBEditor.SafeComWrappers.VBA;
 
 namespace Rubberduck.API

RetailCoder.VBE/Common/Hotkeys/Hotkey.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Windows.Forms;
-using System.Windows.Input;
 using Rubberduck.Common.WinAPI;
 using NLog;
 using Rubberduck.UI;

RetailCoder.VBE/Common/Hotkeys/IHotkey.cs

@@ -1,5 +1,4 @@
 using System.Windows.Forms;
-using System.Windows.Input;
 using Rubberduck.UI.Command;
 
 namespace Rubberduck.Common.Hotkeys

RetailCoder.VBE/Common/StringExtensions.cs

@@ -1,9 +1,5 @@
 using System;
-using System.Collections.Generic;
 using System.Globalization;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Rubberduck.Common
 {

RetailCoder.VBE/Inspections/Concrete/Inspector.cs

@@ -43,7 +43,7 @@ private void UpdateInspectionSeverity(Configuration config)
                 {
                     foreach (var setting in config.UserSettings.CodeInspectionSettings.CodeInspections)
                     {
-                        if (inspection.Description == setting.Description)
+                        if (inspection.Name == setting.Name)
                         {
                             inspection.Severity = setting.Severity;
                         }

RetailCoder.VBE/Inspections/EmptyStringLiteralInspection.cs

@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using System.Linq;
-using Antlr4.Runtime;
 using Rubberduck.Inspections.Abstract;
 using Rubberduck.Inspections.Resources;
 using Rubberduck.Inspections.Results;
@@ -20,7 +19,7 @@ public EmptyStringLiteralInspection(RubberduckParserState state)
         }
 
         public override string Meta { get { return InspectionsUI.EmptyStringLiteralInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.EmptyStringLiteralInspection; } }
+        public override string Description { get { return InspectionsUI.EmptyStringLiteralInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.LanguageOpportunities; } }
 
         public IEnumerable<QualifiedContext<VBAParser.LiteralExpressionContext>> ParseTreeResults { get { return _parseTreeResults.OfType<QualifiedContext<VBAParser.LiteralExpressionContext>>(); } }

RetailCoder.VBE/Inspections/ImplicitActiveSheetReferenceInspection.cs

@@ -21,7 +21,7 @@ public ImplicitActiveSheetReferenceInspection(IVBE vbe, RubberduckParserState st
         }
 
         public override string Meta { get { return InspectionsUI.ImplicitActiveSheetReferenceInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.ImplicitActiveSheetReferenceInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.ImplicitActiveSheetReferenceInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
 
         private static readonly string[] Targets = 

RetailCoder.VBE/Inspections/ImplicitActiveWorkbookReferenceInspection.cs

@@ -21,7 +21,7 @@ public ImplicitActiveWorkbookReferenceInspection(IVBE vbe, RubberduckParserState
         }
 
         public override string Meta { get { return InspectionsUI.ImplicitActiveWorkbookReferenceInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.ImplicitActiveWorkbookReferenceInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.ImplicitActiveWorkbookReferenceInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
 
         private static readonly string[] Targets =

RetailCoder.VBE/Inspections/ImplicitDefaultMemberAssignmentInspection.cs

@@ -0,0 +1,41 @@
+using System.Collections.Generic;
+using System.Linq;
+using Rubberduck.Inspections.Abstract;
+using Rubberduck.Inspections.Resources;
+using Rubberduck.Inspections.Results;
+using Rubberduck.Parsing.Grammar;
+using Rubberduck.Parsing.Symbols;
+using Rubberduck.Parsing.VBA;
+
+namespace Rubberduck.Inspections
+{
+    public sealed class ImplicitDefaultMemberAssignmentInspection : InspectionBase
+    {
+        public ImplicitDefaultMemberAssignmentInspection(RubberduckParserState state)
+            : base(state, CodeInspectionSeverity.Suggestion)
+        {
+        }
+
+        public override IEnumerable<InspectionResultBase> GetInspectionResults()
+        {
+            var interestingDeclarations =
+                State.AllDeclarations.Where(item =>
+                    item.AsTypeDeclaration != null
+                    && ClassModuleDeclaration.HasDefaultMember(item.AsTypeDeclaration));
+
+            var interestingReferences = interestingDeclarations
+                .SelectMany(declaration => declaration.References)
+                .Where(reference =>
+                {
+                    var letStmtContext = ParserRuleContextHelper.GetParent<VBAParser.LetStmtContext>(reference.Context);
+                    return reference.IsAssignment && letStmtContext != null && letStmtContext.LET() == null;
+                });
+
+            return interestingReferences.Select(reference => new ImplicitDefaultMemberAssignmentInspectionResult(this, reference));
+        }
+
+        public override string Meta { get { return InspectionsUI.ImplicitDefaultMemberAssignmentInspectionMeta; } }
+        public override string Description { get { return InspectionsUI.ImplicitDefaultMemberAssignmentInspectionName; } }
+        public override CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
+    }
+}

RetailCoder.VBE/Inspections/MissingAnnotationArgumentInspection.cs

@@ -20,7 +20,7 @@ public MissingAnnotationArgumentInspection(RubberduckParserState state)
         }
 
         public override string Meta { get { return InspectionsUI.MissingAnnotationArgumentInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.MissingAnnotationArgumentInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.MissingAnnotationArgumentInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.CodeQualityIssues; } }
         public IEnumerable<QualifiedContext<VBAParser.AnnotationContext>> ParseTreeResults { get { return _parseTreeResults.OfType<QualifiedContext<VBAParser.AnnotationContext>>(); } }