Made the ParseCoordinator remove all references upon reparse and not only those to the built-in declarations and the modules that have been modified.

Author: MDoerner

Rubberduck.Parsing/VBA/ParseCoordinator.cs

@@ -215,7 +215,7 @@ private void ExecuteCommonParseActivities(List<IVBComponent> toParse, Cancellati
                 token.ThrowIfCancellationRequested();
 
             _projectDeclarations.Clear();
-            State.ClearBuiltInReferences();
+            State.ClearAllReferences();
 
             ParseComponents(toParse, token);
 
@@ -612,7 +612,7 @@ private void ParseAllInternal(object requestor, CancellationToken token)
 
                 token.ThrowIfCancellationRequested();
 
-            var componentsRemoved = ClearStateCashForRemovedComponents(components);
+            var componentsRemoved = CleanUpRemovedComponents(components);
 
                 token.ThrowIfCancellationRequested();
 
@@ -642,10 +642,10 @@ private void ParseAllInternal(object requestor, CancellationToken token)
         }
 
         /// <summary>
-        /// Clears state cach for removed components.
+        /// Clears state cache of removed components.
         /// Returns whether components have been removed.
         /// </summary>
-        private bool ClearStateCashForRemovedComponents(List<IVBComponent> components)
+        private bool CleanUpRemovedComponents(List<IVBComponent> components)
         {
             var removedModuledecalrations = RemovedModuleDeclarations(components);
             var componentRemoved = removedModuledecalrations.Any();

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -742,6 +742,14 @@ public void ClearBuiltInReferences()
             }
         }
 
+        public void ClearAllReferences()
+        {
+            foreach (var declaration in AllDeclarations)
+            {
+                declaration.ClearReferences();
+            }
+        }
+
         public bool ClearStateCache(IVBComponent component, bool notifyStateChanged = false)
         {
             return component != null && ClearStateCache(new QualifiedModuleName(component), notifyStateChanged);