Skip to content

Commit 88d63ce

Browse files
committed
thanks @mjolka! (changed HashSet<T> for IReadOnlyList<T> for _moduleTypes and _memberTypes)
1 parent 8786af5 commit 88d63ce

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

Rubberduck.Parsing/Symbols/IdentifierReferenceResolver.cs

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ private enum ContextAccessorType
1919
private readonly Declarations _declarations;
2020
private readonly QualifiedModuleName _qualifiedModuleName;
2121

22-
private readonly HashSet<DeclarationType> _moduleTypes;
23-
private readonly HashSet<DeclarationType> _memberTypes;
22+
private readonly IReadOnlyList<DeclarationType> _moduleTypes;
23+
private readonly IReadOnlyList<DeclarationType> _memberTypes;
2424

2525
private readonly Stack<Declaration> _withBlockQualifiers;
2626
private readonly HashSet<RuleContext> _alreadyResolved;
@@ -33,14 +33,14 @@ public IdentifierReferenceResolver(QualifiedModuleName qualifiedModuleName, Decl
3333
_withBlockQualifiers = new Stack<Declaration>();
3434
_alreadyResolved = new HashSet<RuleContext>();
3535

36-
_moduleTypes = new HashSet<DeclarationType>(new[]
36+
_moduleTypes = new List<DeclarationType>(new[]
3737
{
3838
DeclarationType.Module,
3939
DeclarationType.Class,
4040
DeclarationType.Project
4141
});
4242

43-
_memberTypes = new HashSet<DeclarationType>(new[]
43+
_memberTypes = new List<DeclarationType>(new[]
4444
{
4545
DeclarationType.Function,
4646
DeclarationType.Procedure,
@@ -665,11 +665,8 @@ private Declaration FindModuleScopeProcedure(string identifierName, Declaration
665665
localScope = _currentScope;
666666
}
667667

668-
var result = _declarations[identifierName].Where(item =>
669-
IsProcedure(item) || IsPropertyAccessor(item, accessorType, localScope, isAssignmentTarget))
670-
.ToList();
671-
672-
return result.SingleOrDefault();
668+
return _declarations[identifierName].SingleOrDefault(item =>
669+
IsProcedure(item) || IsPropertyAccessor(item, accessorType, localScope, isAssignmentTarget));
673670
}
674671

675672
private Declaration FindProjectScopeDeclaration(string identifierName)

0 commit comments

Comments
 (0)