Merge pull request #1723 from ThunderFrame/next

retailcoder · retailcoder · commit 88cb6c204886 · 2016-06-07T08:04:51.000-04:00
Careful assignment of ProjectID - Avoids project collisions
diff --git a/Rubberduck.Parsing/VBA/RubberduckParserState.cs b/Rubberduck.Parsing/VBA/RubberduckParserState.cs
@@ -83,10 +83,18 @@ public void AddProject(VBProject project)
                 return;
             }
 
+            //assign a hashcode if no helpfile is present
             if (string.IsNullOrEmpty(project.HelpFile))
             {
                 project.HelpFile = project.GetHashCode().ToString();
             }
+
+            //loop until the helpfile is unique for this host session
+            while (_projects.Any(a => a.Key == project.HelpFile))
+            {
+                project.HelpFile = (project.GetHashCode() ^ project.HelpFile.GetHashCode()).ToString();
+            }
+
             var projectId = project.HelpFile;
             if (!_projects.ContainsKey(projectId))
             {

Original file line number	Diff line number	Diff line change
`@@ -83,10 +83,18 @@ public void AddProject(VBProject project)`
`83`	`83`	`return;`
`84`	`84`	`}`
`85`	`85`
	`86`	`+ //assign a hashcode if no helpfile is present`
`86`	`87`	`if (string.IsNullOrEmpty(project.HelpFile))`
`87`	`88`	`{`
`88`	`89`	`project.HelpFile = project.GetHashCode().ToString();`
`89`	`90`	`}`
	`91`	`+`
	`92`	`+ //loop until the helpfile is unique for this host session`
	`93`	`+ while (_projects.Any(a => a.Key == project.HelpFile))`
	`94`	`+ {`
	`95`	`+ project.HelpFile = (project.GetHashCode() ^ project.HelpFile.GetHashCode()).ToString();`
	`96`	`+ }`
	`97`	`+`
`90`	`98`	`var projectId = project.HelpFile;`
`91`	`99`	`if (!_projects.ContainsKey(projectId))`
`92`	`100`	`{`