Remove multiple conditions, leaving only a single condition to evaluate because conditions are OR'd, not AND'd. Using the unlikely flag will have to suffice. Also remove some stray Debug.Print methods.

Author: bclothier

Rubberduck.VBEEditor/ComManagement/TypeLibs/TypeApiFactory.cs

@@ -26,7 +26,6 @@ internal static ITypeLibWrapper GetTypeLibWrapper(IntPtr rawObjectPtr, bool addR
             return wrapper;
         }
 
-        [Conditional("DEBUG")]
         [Conditional("TRACE_TYPEAPI")]
         private static void TraceWrapper(ref ITypeLibWrapper wrapper)
         {
@@ -47,7 +46,6 @@ internal static ITypeInfoWrapper GetTypeInfoWrapper(ITypeInfo rawTypeInfo)
             return wrapper;
         }
 
-        [Conditional("DEBUG")]
         [Conditional("TRACE_TYPEAPI")]
         private static void TraceWrapper(ref ITypeInfoWrapper wrapper)
         {

Rubberduck.VBEEditor/ComManagement/TypeLibs/Unmanaged/ComPointer.cs

@@ -168,7 +168,6 @@ private void ReleaseUnmanagedResources()
             _disposed = true;
         }
 
-        [Conditional("DEBUG")]
         [Conditional("TRACE_COM_POINTERS")]
         private void TraceRelease(int rcwCount, ref bool addRef)
         {

Rubberduck.VBEEditor/ComManagement/TypeLibs/Unmanaged/RDMarshal.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Diagnostics;
 using System.Linq;
-using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using System.Runtime.InteropServices.ComTypes;
@@ -256,7 +255,6 @@ internal static int QueryInterface(IntPtr pUnk, ref Guid iid, out IntPtr ppv)
                 Debug.Assert(iid_local != Guid.Empty, "Empty IID passed in");
             });
 
-            Debug.Print($"Entering {nameof(QueryInterface)}; {nameof(pUnk)}: {FormatPtr(pUnk)}, {nameof(iid)}: {iid.ToString()}");
             Trace(TraceAction.Entering, pUnk, args: (nameof(iid), iid.ToString()));
             var result = Marshal.QueryInterface(pUnk, ref iid, out ppv);
             Trace(TraceAction.Leaving, pUnk, args: new (string Name, object Value)[]
@@ -312,7 +310,6 @@ internal static int ReleaseComObject(object o)
             Assert(() =>
             {
                 var ptr = Marshal.GetIUnknownForObject(o);
-                Debug.Print($"Entering {nameof(ReleaseComObject)}; {nameof(o)}: {FormatPtr(ptr)}, {o.GetType().Name}");
                 var debugResult = Marshal.Release(ptr);
                 Debug.Assert(debugResult > 0,
                     $"The ref count is at zero or is invalid before calling the {nameof(Marshal.ReleaseComObject)}.");
@@ -403,8 +400,6 @@ private enum TraceAction
             Executing
         }
 
-
-        [Conditional("DEBUG")]
         [Conditional("TRACE_MARSHAL")]
         private static void Trace(TraceAction action, IntPtr pUnk, [CallerMemberName]string MethodName = null, params (string Name, object Value)[] args)
         {
@@ -418,7 +413,6 @@ private static void Trace(TraceAction action, IntPtr pUnk, [CallerMemberName]str
             Debug.Print($"{Enum.GetName(typeof(TraceAction), action)} {MethodName}; {nameof(pUnk)}: {FormatPtr(pUnk)} {argPrint}");
         }
 
-        [Conditional("DEBUG")]
         [Conditional("TRACE_MARSHAL")]
         private static void Trace(TraceAction action, [CallerMemberName]string MethodName = null, params (string Name, object Value)[] args)
         {
@@ -431,21 +425,18 @@ private static void Trace(TraceAction action, [CallerMemberName]string MethodNam
             Debug.Print($"{Enum.GetName(typeof(TraceAction), action)} {MethodName}; {argPrint}");
         }
 
-        [Conditional("DEBUG")]
         [Conditional("TRACE_MARSHAL")]
         private static void Assert(Action assert)
         {
             assert.Invoke();
         }
 
-        [Conditional("DEBUG")]
         [Conditional("REF_COUNT")]
         private static void PrintRefCount(object o, int result)
         {
             Debug.Print($"{nameof(ReleaseComObject)}:: COM Object: {o.GetType().Name} ref count {result}");
         }
 
-        [Conditional("DEBUG")]
         [Conditional("REF_COUNT")]
         private static void PrintRefCount(IntPtr pUnk, [CallerMemberName] string methodName = null, int refCount = 0)
         {
@@ -468,14 +459,12 @@ private static void PrintRefCount(IntPtr pUnk, [CallerMemberName] string methodN
             }
         }
 
-        [Conditional("DEBUG")]
         [Conditional("REF_COUNT")]
         private static void PrintAlloc(IntPtr pUnmanaged, [CallerMemberName] string methodName = null)
         {
             Debug.Print($"{methodName}:: Unmanaged pointer allocated: {FormatPtr(pUnmanaged)}");
         }
 
-        [Conditional("DEBUG")]
         [Conditional("REF_COUNT")]
         private static void PrintFree(IntPtr pUnmanaged, [CallerMemberName] string methodName = null)
         {

Rubberduck.VBEEditor/Events/VBENativeServices.cs

@@ -295,7 +295,6 @@ private static string ToClassName(this IntPtr hwnd)
             return name.ToString();
         }
 
-        [Conditional("DEBUG")]
         [Conditional("THIRSTY_DUCK_EVT")]
         private static void PeekMessagePump(uint eventType, IntPtr hwnd, int idObject, int idChild)
         {

Rubberduck.VBEEditor/SafeComWrappers/SafeComWrapper.cs

@@ -157,7 +157,6 @@ protected virtual void Dispose(bool disposing)
             }
         }
 
-        [Conditional("DEBUG")]
         [Conditional("LOG_COM_RELEASE")]
         private void LogComRelease()
         {

Rubberduck.VBEEditor/WindowsApi/SubclassingWindow.cs

@@ -95,7 +95,6 @@ public virtual int SubClassProc(IntPtr hWnd, IntPtr msg, IntPtr wParam, IntPtr l
             return DefSubclassProc(hWnd, msg, wParam, lParam);
         }
 
-        [Conditional("DEBUG")]
         [Conditional("THIRSTY_DUCK")]
         [Conditional("THIRSTY_DUCK_WM")]
         private static void PeekMessagePump(IntPtr hWnd, IntPtr msg, IntPtr wParam, IntPtr lParam)