Revert "make internals of Rubberduck visible to RubberduckTest and make CodeMetricsAnalyst internal"

Vogel612 · Vogel612 · commit 8794aab79391 · 2017-11-21T22:52:25.000+01:00
This reverts commit 43fab4e. Apparently internal implementations for interfaces are not discovered by Castle Windsor
diff --git a/RetailCoder.VBE/App.cs b/RetailCoder.VBE/App.cs
@@ -15,9 +15,7 @@
 using Rubberduck.VBEditor.SafeComWrappers.Abstract;
 using Rubberduck.VersionCheck;
 using Application = System.Windows.Forms.Application;
-using System.Runtime.CompilerServices;
 
-[assembly: InternalsVisibleTo("RubberduckTests")]
 namespace Rubberduck
 {
     public sealed class App : IDisposable
diff --git a/RetailCoder.VBE/Navigation/CodeMetrics/CodeMetricsAnalyst.cs b/RetailCoder.VBE/Navigation/CodeMetrics/CodeMetricsAnalyst.cs
@@ -10,7 +10,7 @@
 
 namespace Rubberduck.Navigation.CodeMetrics
 {
-    internal class CodeMetricsAnalyst : ICodeMetricsAnalyst
+    public class CodeMetricsAnalyst : ICodeMetricsAnalyst
     {
         private readonly IIndenterSettings indenterSettings;
     

Original file line number	Diff line number	Diff line change
`@@ -15,9 +15,7 @@`
`15`	`15`	`using Rubberduck.VBEditor.SafeComWrappers.Abstract;`
`16`	`16`	`using Rubberduck.VersionCheck;`
`17`	`17`	`using Application = System.Windows.Forms.Application;`
`18`		`-using System.Runtime.CompilerServices;`
`19`	`18`
`20`		`-[assembly: InternalsVisibleTo("RubberduckTests")]`
`21`	`19`	`namespace Rubberduck`
`22`	`20`	`{`
`23`	`21`	`public sealed class App : IDisposable`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`
`11`	`11`	`namespace Rubberduck.Navigation.CodeMetrics`
`12`	`12`	`{`
`13`		`- internal class CodeMetricsAnalyst : ICodeMetricsAnalyst`
	`13`	`+ public class CodeMetricsAnalyst : ICodeMetricsAnalyst`
`14`	`14`	`{`
`15`	`15`	`private readonly IIndenterSettings indenterSettings;`
`16`	`16`