Skip to content

Commit 8668b13

Browse files
committed
Unignore tests passing now
1 parent 7a7f2e7 commit 8668b13

File tree

6 files changed

+6
-9
lines changed

6 files changed

+6
-9
lines changed

RubberduckTests/Grammar/ResolverTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3096,7 +3096,7 @@ End Function
30963096
[Category("Grammar")]
30973097
[Category("Resolver")]
30983098
[Test]
3099-
public void ChainedDictionaryAccessExpressionHasReferenceToDefaultMemberAtSecondExclamationMark()
3099+
public void ChainedDictionaryAccessExpressionHasReferenceToDefaultMemberAtFirstExclamationMark()
31003100
{
31013101
var class1Code = @"
31023102
Public Function Foo(bar As String) As Class2
@@ -3144,7 +3144,7 @@ End Function
31443144
[Category("Grammar")]
31453145
[Category("Resolver")]
31463146
[Test]
3147-
public void ChainedDictionaryAccessExpressionHasReferenceToDefaultMemberAtFirstExclamationMark()
3147+
public void ChainedDictionaryAccessExpressionHasReferenceToDefaultMemberAtSecondExclamationMark()
31483148
{
31493149
var class1Code = @"
31503150
Public Function Foo(bar As String) As Class2

RubberduckTests/Grammar/VBAParserTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3170,7 +3170,7 @@ End Sub
31703170

31713171

31723172
[Test]
3173-
[Ignore("This cannot work with the current setup of identifiers bacause the SLL parser confuses the bang for a type hint.")]
3173+
[Ignore("This cannot work with the current setup of identifiers because the SLL parser confuses the bang for a type hint.")]
31743174
public void ParserDoesNotFailOnBangOperatorOnForeignIdentifier()
31753175
{
31763176
const string code = @"
@@ -3201,7 +3201,7 @@ End Sub
32013201

32023202

32033203
[Test]
3204-
[Ignore("This cannot work with the current setup of identifiers bacause the SLL parser confuses the bang for a type hint.")]
3204+
[Ignore("This cannot work with the current setup of identifiers because the SLL parser confuses the bang for a type hint.")]
32053205
public void ParserDoesNotFailOnStackedBangOperator_ForeignIdentifier()
32063206
{
32073207
const string code = @"

RubberduckTests/Inspections/ImplicitActiveWorkbookReferenceInspectionTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ namespace RubberduckTests.Inspections
1111
public class ImplicitActiveWorkbookReferenceInspectionTests
1212
{
1313
[Test]
14-
[Ignore("This was apparently only passing due to the test setup. See #4404")]
1514
[Category("Inspections")]
1615
public void ImplicitActiveWorkbookReference_ReportsWorksheets()
1716
{

RubberduckTests/Inspections/ObjectVariableNotSetInspectionTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,9 +304,9 @@ Dim enumVariable As TestEnum
304304

305305
// This is a corner case similar to #4037. Previously, Collection's default member was not being generated correctly in
306306
// when it was loaded by the COM collector (_Collection is missing the default interface flag). After picking up that member
307-
// this test fails because it resolves as attempting to assign 'New Colletion' to `Test.DefaultMember`.
307+
// this test fails because it resolves as attempting to assign 'New Collection' to `Test.DefaultMember`.
308308
[Test]
309-
[Ignore("Broken by COM collector fix. See comment on test.")]
309+
//[Ignore("Broken by COM collector fix. See comment on test.")]
310310
[Category("Inspections")]
311311
public void ObjectVariableNotSet_FunctionReturnNotSet_ReturnsResult()
312312
{

RubberduckTests/Inspections/SheetAccessedUsingStringInspectionTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ namespace RubberduckTests.Inspections
1414
public class SheetAccessedUsingStringInspectionTests
1515
{
1616
[Test]
17-
[Ignore("See #4411")]
1817
[Category("Inspections")]
1918
public void SheetAccessedUsingString_ReturnsResult_AccessingUsingWorkbookModule()
2019
{

RubberduckTests/Symbols/DeclarationFinderTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1182,7 +1182,6 @@ Dim sht As WorkSheet
11821182

11831183
[Category("Resolver")]
11841184
[Test]
1185-
//[Ignore("Need to fix the default member access for function calls; see case #3937")]
11861185
public void Identify_NamedParameter_Parameter_FromExcel_DefaultAccess()
11871186
{
11881187
// Note that ColumnIndex is actually a parameter of the _Default default member

0 commit comments

Comments
 (0)