Handle the globals for encapuslate field inspection

Author: bclothier

Rubberduck.CodeAnalysis/Inspections/Concrete/EncapsulatePublicFieldInspection.cs

@@ -40,8 +40,9 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             // we're creating a public field for every control on a form, needs to be ignored.
             var fields = State.DeclarationFinder.UserDeclarations(DeclarationType.Variable)
-                .Where(item => item.Accessibility == Accessibility.Public
-                               && (item.DeclarationType != DeclarationType.Control))
+                .Where(item => item.DeclarationType != DeclarationType.Control
+                               && (item.Accessibility == Accessibility.Public ||
+                                   item.Accessibility == Accessibility.Global))
                 .ToList();
 
             return fields

RubberduckTests/Inspections/EncapsulatePublicFieldInspectionTests.cs

@@ -7,18 +7,32 @@
 namespace RubberduckTests.Inspections
 {
     [TestFixture]
+    [Category("EncapsulatePublicFieldInspection")]
     public class EncapsulatePublicFieldInspectionTests
     {
         [Test]
-        [Category("Inspections")]
         public void PublicField_ReturnsResult()
         {
             const string inputCode =
                 @"Public fizz As Boolean";
             var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
             using (var state = MockParser.CreateAndParse(vbe.Object))
             {
+                var inspection = new EncapsulatePublicFieldInspection(state);
+                var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
+
+                Assert.AreEqual(1, inspectionResults.Count());
+            }
+        }
 
+        [Test]
+        public void GlobalField_ReturnsResult()
+        {
+            const string inputCode =
+                @"Global fizz As Boolean";
+            var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
                 var inspection = new EncapsulatePublicFieldInspection(state);
                 var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
 
@@ -27,7 +41,6 @@ public void PublicField_ReturnsResult()
         }
 
         [Test]
-        [Category("Inspections")]
         public void MultiplePublicFields_ReturnMultipleResult()
         {
             const string inputCode =
@@ -46,15 +59,13 @@ public void MultiplePublicFields_ReturnMultipleResult()
         }
 
         [Test]
-        [Category("Inspections")]
         public void PrivateField_DoesNotReturnResult()
         {
             const string inputCode =
                 @"Private fizz As Boolean";
             var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
             using (var state = MockParser.CreateAndParse(vbe.Object))
             {
-
                 var inspection = new EncapsulatePublicFieldInspection(state);
                 var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
 
@@ -63,7 +74,6 @@ public void PrivateField_DoesNotReturnResult()
         }
 
         [Test]
-        [Category("Inspections")]
         public void PublicNonField_DoesNotReturnResult()
         {
             const string inputCode =
@@ -72,7 +82,6 @@ public void PublicNonField_DoesNotReturnResult()
             var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
             using (var state = MockParser.CreateAndParse(vbe.Object))
             {
-
                 var inspection = new EncapsulatePublicFieldInspection(state);
                 var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
 
@@ -81,7 +90,6 @@ public void PublicNonField_DoesNotReturnResult()
         }
 
         [Test]
-        [Category("Inspections")]
         public void PublicField_Ignored_DoesNotReturnResult()
         {
             const string inputCode =
@@ -90,7 +98,6 @@ public void PublicField_Ignored_DoesNotReturnResult()
             var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
             using (var state = MockParser.CreateAndParse(vbe.Object))
             {
-
                 var inspection = new EncapsulatePublicFieldInspection(state);
                 var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
 
@@ -99,7 +106,6 @@ public void PublicField_Ignored_DoesNotReturnResult()
         }
 
         [Test]
-        [Category("Inspections")]
         public void InspectionName()
         {
             const string inspectionName = "EncapsulatePublicFieldInspection";