Essentially close #1681

Author: Hosch250

RetailCoder.VBE/Inspections/Inspector.cs

@@ -25,10 +25,10 @@ public Inspector(IGeneralConfigService configService, IEnumerable<IInspection> i
                 _inspections = inspections;
 
                 _configService = configService;
-                configService.SettingsChanged += ConfigServiceLanguageChanged;
+                configService.SettingsChanged += ConfigServiceSettingsChanged;
             }
 
-            private void ConfigServiceLanguageChanged(object sender, EventArgs e)
+            private void ConfigServiceSettingsChanged(object sender, EventArgs e)
             {
                 UpdateInspectionSeverity();
             }
@@ -125,7 +125,7 @@ public void Dispose()
             {
                 if (_configService != null)
                 {
-                    _configService.SettingsChanged -= ConfigServiceLanguageChanged;
+                    _configService.SettingsChanged -= ConfigServiceSettingsChanged;
                 }
             }
         }

RetailCoder.VBE/Inspections/UseMeaningfulNameInspection.cs

@@ -1,29 +1,43 @@
 using System;
 using System.Collections.Generic;
+using System.IO;
 using System.Linq;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
+using Rubberduck.Settings;
+using Rubberduck.SettingsProvider;
 using Rubberduck.UI;
 
 namespace Rubberduck.Inspections
 {
     public sealed class UseMeaningfulNameInspection : InspectionBase
     {
         private readonly IMessageBox _messageBox;
+        private readonly IPersistanceService<CodeInspectionSettings> _settings;
 
-        public UseMeaningfulNameInspection(IMessageBox messageBox, RubberduckParserState state)
+        public UseMeaningfulNameInspection(IMessageBox messageBox, RubberduckParserState state, IPersistanceService<CodeInspectionSettings> settings)
             : base(state, CodeInspectionSeverity.Suggestion)
         {
             _messageBox = messageBox;
+            _settings = settings;
         }
 
         public override string Description { get { return InspectionsUI.UseMeaningfulNameInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
 
         public override IEnumerable<InspectionResultBase> GetInspectionResults()
         {
+            var whitelistedNames = new List<string>();
+
+            try
+            {
+                whitelistedNames = _settings.Load(new CodeInspectionSettings()).WhitelistedNames.Select(s => s.Name).ToList();
+            }
+            catch (IOException) { }
+
             var issues = UserDeclarations
-                            .Where(declaration => declaration.DeclarationType != DeclarationType.ModuleOption && 
+                            .Where(declaration => declaration.DeclarationType != DeclarationType.ModuleOption &&
+                                                  !whitelistedNames.Contains(declaration.IdentifierName) &&
                                                   (declaration.IdentifierName.Length < 3 ||
                                                   char.IsDigit(declaration.IdentifierName.Last()) ||
                                                   !declaration.IdentifierName.Any(c => 

RetailCoder.VBE/Root/RubberduckModule.cs

@@ -85,7 +85,7 @@ public override void Load()
 
             BindCommandsToMenuItems();
 
-            Rebind<Rubberduck.Parsing.ISinks>().To<Sinks>().InSingletonScope();
+            Rebind<ISinks>().To<Sinks>().InSingletonScope();
             Rebind<IIndenter>().To<Indenter>().InSingletonScope();
             Rebind<IIndenterSettings>().To<IndenterSettings>();
             Bind<Func<IIndenterSettings>>().ToMethod(t => () => Kernel.Get<IGeneralConfigService>().LoadConfiguration().UserSettings.IndenterSettings);

RetailCoder.VBE/Rubberduck.csproj

@@ -404,6 +404,7 @@
     <Compile Include="Settings\RubberduckHotkey.cs" />
     <Compile Include="Settings\ToDoListConfigProvider.cs" />
     <Compile Include="Settings\UnitTestConfigProvider.cs" />
+    <Compile Include="Settings\WhitelistedNameSetting.cs" />
     <Compile Include="Sinks.cs" />
     <Compile Include="UI\About\AboutControl.xaml.cs">
       <DependentUpon>AboutControl.xaml</DependentUpon>

RetailCoder.VBE/Settings/CodeInspectionConfigProvider.cs

@@ -27,14 +27,16 @@ public CodeInspectionSettings Create(IEnumerable<IInspection> inspections)
             if (inspections == null) return null;
 
             _inspections = inspections;
-            var prototype = new CodeInspectionSettings(GetDefaultCodeInspections());
+            var prototype = new CodeInspectionSettings(GetDefaultCodeInspections(), new WhitelistedNameSetting[] {});
             return _persister.Load(prototype) ?? prototype;
         }
 
         public CodeInspectionSettings CreateDefaults()
         {
             //This sucks.
-            return _inspections != null ? new CodeInspectionSettings(GetDefaultCodeInspections()) : null;
+            return _inspections != null
+                ? new CodeInspectionSettings(GetDefaultCodeInspections(), new WhitelistedNameSetting[] {})
+                : null;
         }
 
         public void Save(CodeInspectionSettings settings)

RetailCoder.VBE/Settings/CodeInspectionSettings.cs

@@ -10,6 +10,7 @@ namespace Rubberduck.Settings
     public interface ICodeInspectionSettings
     {
         HashSet<CodeInspectionSetting> CodeInspections { get; set; }
+        WhitelistedNameSetting[] WhitelistedNames { get; set; }
     }
 
     [XmlType(AnonymousType = true)]
@@ -18,14 +19,17 @@ public class CodeInspectionSettings : ICodeInspectionSettings
         [XmlArrayItem("CodeInspection", IsNullable = false)]
         public HashSet<CodeInspectionSetting> CodeInspections { get; set; }
 
-        public CodeInspectionSettings()
+        [XmlArrayItem("WhitelistedName", IsNullable = false)]
+        public WhitelistedNameSetting[] WhitelistedNames { get; set; }
+
+        public CodeInspectionSettings() : this(new HashSet<CodeInspectionSetting>(), new WhitelistedNameSetting[] {})
         {
-            CodeInspections =new HashSet<CodeInspectionSetting>();
         }
 
-        public CodeInspectionSettings(HashSet<CodeInspectionSetting> inspections)
+        public CodeInspectionSettings(HashSet<CodeInspectionSetting> inspections, WhitelistedNameSetting[] whitelistedNames)
         {
             CodeInspections = inspections;
+            WhitelistedNames = whitelistedNames;
         }
 
         public CodeInspectionSetting GetSetting(Type inspection)

RetailCoder.VBE/Settings/WhitelistedNameSetting.cs

@@ -0,0 +1,18 @@
+using System.Xml.Serialization;
+
+namespace Rubberduck.Settings
+{
+    [XmlType(AnonymousType = true)]
+    public class WhitelistedNameSetting
+    {
+        [XmlAttribute]
+        public string Name { get; set; }
+
+        public WhitelistedNameSetting(string name)
+        {
+            Name = name;
+        }
+
+        public WhitelistedNameSetting() : this("*") { }
+    }
+}

RetailCoder.VBE/UI/RubberduckUI.Designer.cs

@@ -1763,4 +1763,7 @@ All our stargazers, likers & followers, for the warm fuzzies
   <data name="RegexAssistant_Title" xml:space="preserve">
     <value>Regular Expression Analyzer</value>
   </data>
+  <data name="CodeInspectionSettings_WhitelistedNamesLabel" xml:space="preserve">
+    <value>Whitelisted Names</value>
+  </data>
 </root>