Clarify ExperimentalFeatureTypes usage

Author: Vogel612

Rubberduck.Core/Common/ModuleExporter.cs

@@ -11,8 +11,8 @@ public class ModuleExporter : IModuleExporter
 
         public string ExportPath => TempFile
             ? ApplicationConstants.RUBBERDUCK_TEMP_PATH
-            // FIXME check that GetExecutingAssembly is similarly acceptable as .GetAssembly(typeof(App))
-            : Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
+            // note that App is not in the entry-point assembly, since Core is not the entry point anymore
+            : Path.GetDirectoryName(Assembly.GetAssembly(typeof(App)).Location);
 
         public string Export(IVBComponent component, bool tempFile = true)
         {

Rubberduck.Core/UI/Settings/GeneralSettingsViewModel.cs

@@ -5,8 +5,6 @@
 using Rubberduck.Settings;
 using Rubberduck.Common;
 using NLog;
-using Rubberduck.Parsing.Common;
-//using Rubberduck.Root;
 using Rubberduck.SettingsProvider;
 using Rubberduck.UI.Command;
 
@@ -27,7 +25,7 @@ public class GeneralSettingsViewModel : SettingsViewModelBase, ISettingsViewMode
         public GeneralSettingsViewModel(Configuration config, IOperatingSystem operatingSystem, IEnumerable<Type> experimentalFeatureTypes)
         {
             _operatingSystem = operatingSystem;
-            _experimentalFeatureTypes = new ReadOnlyCollection<Type>(experimentalFeatureTypes.ToList());
+            _experimentalFeatureTypes = experimentalFeatureTypes.ToList().AsReadOnly();
             Languages = new ObservableCollection<DisplayLanguageSetting>(
                 new[] 
             {
@@ -231,9 +229,6 @@ private void TransferSettingsToView(IGeneralSettings general, IHotkeySettings ho
             AutoSavePeriod = general.AutoSavePeriod;
             SelectedLogLevel = LogLevels.First(l => l.Ordinal == general.MinimumLogLevel);
 
-            //RubberduckIoCInstaller.AssembliesToRegister()
-            //    .SelectMany(s => s.DefinedTypes)
-            //    .Where(w => Attribute.IsDefined(w, typeof(ExperimentalAttribute)))
             ExperimentalFeatures = _experimentalFeatureTypes
                 .SelectMany(s => s.CustomAttributes.Where(a => a.ConstructorArguments.Any()).Select(a => (string)a.ConstructorArguments.First().Value))
                 .Distinct()

Rubberduck.Core/UI/Settings/SettingsForm.cs

@@ -22,7 +22,15 @@ public SettingsForm(IGeneralConfigService configService, IOperatingSystem operat
                 config,
                 new SettingsView
                 {
-                    Control = new GeneralSettings(new GeneralSettingsViewModel(config, operatingSystem, new ReadOnlyCollection<Type>(new List<Type>()))),
+                    // FIXME inject types marked as ExperimentalFeatures
+                    /* 
+                     * These ExperimentalFeatureTypes were originally obtained by directly calling into the IoC container 
+                     * (since only it knows, which Assemblies have been loaded as Plugins). The code is preserved here for easy access.
+                     * RubberduckIoCInstaller.AssembliesToRegister()
+                     *     .SelectMany(s => s.DefinedTypes)
+                     *     .Where(w => Attribute.IsDefined(w, typeof(ExperimentalAttribute)))
+                     */
+                    Control = new GeneralSettings(new GeneralSettingsViewModel(config, operatingSystem, new List<Type>())),
                     View = SettingsViews.GeneralSettings
                 },
                 new SettingsView