Fixed missing null check in BooleanIsAssignedInIfStmt inspection.

MDoerner · MDoerner · commit 84392962a85d · 2017-10-28T11:48:36.000+02:00
diff --git a/Rubberduck.Inspections/Concrete/BooleanAssignedInIfElseInspection.cs b/Rubberduck.Inspections/Concrete/BooleanAssignedInIfElseInspection.cs
@@ -48,7 +48,12 @@ public void ClearContexts()
 
             public override void ExitIfStmt(VBAParser.IfStmtContext context)
             {
-                if (context.elseIfBlock().Any())
+                if (context.elseIfBlock() != null && context.elseIfBlock().Any())
+                {
+                    return;
+                }
+
+                if (context.elseBlock() == null)
                 {
                     return;
                 }
@@ -60,6 +65,7 @@ public override void ExitIfStmt(VBAParser.IfStmtContext context)
                 }
 
                 // make sure the assignments are the opposite
+
                 if (!(ParserRuleContextHelper.GetDescendent<VBAParser.BooleanLiteralIdentifierContext>(context.block()).GetText() == Tokens.True ^
                       ParserRuleContextHelper.GetDescendent<VBAParser.BooleanLiteralIdentifierContext>(context.elseBlock().block()).GetText() == Tokens.True))
                 {

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,12 @@ public void ClearContexts()`
`48`	`48`
`49`	`49`	`public override void ExitIfStmt(VBAParser.IfStmtContext context)`
`50`	`50`	`{`
`51`		`- if (context.elseIfBlock().Any())`
	`51`	`+ if (context.elseIfBlock() != null && context.elseIfBlock().Any())`
	`52`	`+ {`
	`53`	`+ return;`
	`54`	`+ }`
	`55`	`+`
	`56`	`+ if (context.elseBlock() == null)`
`52`	`57`	`{`
`53`	`58`	`return;`
`54`	`59`	`}`
`@@ -60,6 +65,7 @@ public override void ExitIfStmt(VBAParser.IfStmtContext context)`
`60`	`65`	`}`
`61`	`66`
`62`	`67`	`// make sure the assignments are the opposite`
	`68`	`+`
`63`	`69`	`if (!(ParserRuleContextHelper.GetDescendent<VBAParser.BooleanLiteralIdentifierContext>(context.block()).GetText() == Tokens.True ^`
`64`	`70`	`ParserRuleContextHelper.GetDescendent<VBAParser.BooleanLiteralIdentifierContext>(context.elseBlock().block()).GetText() == Tokens.True))`
`65`	`71`	`{`