make preprocessor always use "option compare text" mode

Author: Andrin Meier

Rubberduck.Parsing/Preprocessing/LogicalEqualsExpression.cs

@@ -4,13 +4,11 @@ public sealed class LogicalEqualsExpression : Expression
     {
         private readonly IExpression _left;
         private readonly IExpression _right;
-        private readonly VBAOptionCompare _optionCompare;
 
-        public LogicalEqualsExpression(IExpression left, IExpression right, VBAOptionCompare optionCompare)
+        public LogicalEqualsExpression(IExpression left, IExpression right)
         {
             _left = left;
             _right = right;
-            _optionCompare = optionCompare;
         }
 
         public override IValue Evaluate()
@@ -27,14 +25,7 @@ public override IValue Evaluate()
             {
                 var leftValue = left.AsString;
                 var rightValue = right.AsString;
-                if (_optionCompare == VBAOptionCompare.Binary)
-                {
-                    return new BoolValue(string.CompareOrdinal(leftValue, rightValue) == 0);
-                }
-                else
-                {
-                    return new BoolValue(leftValue.CompareTo(rightValue) == 0);
-                }
+                return new BoolValue(leftValue.CompareTo(rightValue) == 0);
             }
             else
             {

Rubberduck.Parsing/Preprocessing/LogicalGreaterOrEqualsExpression.cs

@@ -4,18 +4,16 @@ public sealed class LogicalGreaterOrEqualsExpression : Expression
     {
         private readonly IExpression _left;
         private readonly IExpression _right;
-        private readonly VBAOptionCompare _optionCompare;
 
-        public LogicalGreaterOrEqualsExpression(IExpression left, IExpression right, VBAOptionCompare optionCompare)
+        public LogicalGreaterOrEqualsExpression(IExpression left, IExpression right)
         {
             _left = left;
             _right = right;
-            _optionCompare = optionCompare;
         }
 
         public override IValue Evaluate()
         {
-            var result = new LogicalLessThanExpression(_left, _right, _optionCompare).Evaluate();
+            var result = new LogicalLessThanExpression(_left, _right).Evaluate();
             if (result == null)
             {
                 return null;

Rubberduck.Parsing/Preprocessing/LogicalGreaterThanExpression.cs

@@ -4,19 +4,17 @@ public sealed class LogicalGreaterThanExpression : Expression
     {
         private readonly IExpression _left;
         private readonly IExpression _right;
-        private readonly VBAOptionCompare _optionCompare;
 
-        public LogicalGreaterThanExpression(IExpression left, IExpression right, VBAOptionCompare optionCompare)
+        public LogicalGreaterThanExpression(IExpression left, IExpression right)
         {
             _left = left;
             _right = right;
-            _optionCompare = optionCompare;
         }
 
         public override IValue Evaluate()
         {
-            var lt = new LogicalLessThanExpression(_left, _right, _optionCompare).Evaluate();
-            var eq = new LogicalEqualsExpression(_left, _right, _optionCompare).Evaluate();
+            var lt = new LogicalLessThanExpression(_left, _right).Evaluate();
+            var eq = new LogicalEqualsExpression(_left, _right).Evaluate();
             if (lt == null || eq == null)
             {
                 return null;

Rubberduck.Parsing/Preprocessing/LogicalLessOrEqualsExpression.cs

@@ -4,19 +4,17 @@ public sealed class LogicalLessOrEqualsExpression : Expression
     {
         private readonly IExpression _left;
         private readonly IExpression _right;
-        private readonly VBAOptionCompare _optionCompare;
 
-        public LogicalLessOrEqualsExpression(IExpression left, IExpression right, VBAOptionCompare optionCompare)
+        public LogicalLessOrEqualsExpression(IExpression left, IExpression right)
         {
             _left = left;
             _right = right;
-            _optionCompare = optionCompare;
         }
 
         public override IValue Evaluate()
         {
-            var lt = new LogicalLessThanExpression(_left, _right, _optionCompare).Evaluate();
-            var eq = new LogicalEqualsExpression(_left, _right, _optionCompare).Evaluate();
+            var lt = new LogicalLessThanExpression(_left, _right).Evaluate();
+            var eq = new LogicalEqualsExpression(_left, _right).Evaluate();
             if (lt == null || eq == null)
             {
                 return null;

Rubberduck.Parsing/Preprocessing/LogicalLessThanExpression.cs

@@ -4,13 +4,11 @@ public sealed class LogicalLessThanExpression : Expression
     {
         private readonly IExpression _left;
         private readonly IExpression _right;
-        private readonly VBAOptionCompare _optionCompare;
 
-        public LogicalLessThanExpression(IExpression left, IExpression right, VBAOptionCompare optionCompare)
+        public LogicalLessThanExpression(IExpression left, IExpression right)
         {
             _left = left;
             _right = right;
-            _optionCompare = optionCompare;
         }
 
         public override IValue Evaluate()
@@ -26,14 +24,7 @@ public override IValue Evaluate()
             {
                 var leftValue = left.AsString;
                 var rightValue = right.AsString;
-                if (_optionCompare == VBAOptionCompare.Binary)
-                {
-                    return new BoolValue(string.CompareOrdinal(leftValue, rightValue) < 0);
-                }
-                else
-                {
-                    return new BoolValue(leftValue.CompareTo(rightValue) < 0);
-                }
+                return new BoolValue(leftValue.CompareTo(rightValue) < 0);
             }
             else
             {

Rubberduck.Parsing/Preprocessing/LogicalNotEqualsExpression.cs

@@ -4,18 +4,16 @@ public sealed class LogicalNotEqualsExpression : Expression
     {
         private readonly IExpression _left;
         private readonly IExpression _right;
-        private readonly VBAOptionCompare _optionCompare;
 
-        public LogicalNotEqualsExpression(IExpression left, IExpression right, VBAOptionCompare optionCompare)
+        public LogicalNotEqualsExpression(IExpression left, IExpression right)
         {
             _left = left;
             _right = right;
-            _optionCompare = optionCompare;
         }
 
         public override IValue Evaluate()
         {
-            var eq = new LogicalEqualsExpression(_left, _right, _optionCompare).Evaluate();
+            var eq = new LogicalEqualsExpression(_left, _right).Evaluate();
             if (eq == null)
             {
                 return null;

Rubberduck.Parsing/Preprocessing/OptionCompareListener.cs

@@ -3,7 +3,7 @@
 
 namespace Rubberduck.Parsing.Preprocessing
 {
-    public static class VBAEnvironment
+    public static class VBALibrary
     {
         private static readonly Dictionary<string, Func<IExpression, IExpression>> _libraryFunctions = new Dictionary<string, Func<IExpression, IExpression>>()
         {