Add predeclared indicator to name with signature and custom icon. Closes #3703

Author: comintern

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerComponentViewModel.cs

@@ -37,10 +37,7 @@ public CodeExplorerComponentViewModel(CodeExplorerItemViewModel parent, Declarat
             : base(declaration)
         {
             Parent = parent;
-
-            _icon = Icons.ContainsKey(DeclarationType) 
-                ? Icons[DeclarationType]
-                : GetImageSource(CodeExplorerUI.status_offline);
+            SetIcon();
 
             Items = declarations.GroupBy(item => item.Scope).SelectMany(grouping =>
                             grouping.Where(item => item.ParentDeclaration != null
@@ -166,8 +163,13 @@ public bool IsTestModule
 
         private readonly string _name;
         public override string Name => _name;
-  
-        public override string NameWithSignature => _name;
+
+        public override string NameWithSignature =>
+            $"{_name}{(IsPredeclared ? " (Predeclared)" : string.Empty)}";
+
+        private bool IsPredeclared => Declaration != null &&
+                                      Declaration.Attributes.HasPredeclaredIdAttribute(out _) &&
+                                      Declaration.IsUserDefined;
 
         public override QualifiedSelection? QualifiedSelection => Declaration.QualifiedSelection;
 
@@ -206,6 +208,9 @@ private DeclarationType DeclarationType
             }
         }
 
+        private static readonly BitmapImage PredeclaredIcon = GetImageSource(CodeExplorerUI.ObjectClassPredeclared);
+        private static readonly BitmapImage OopsIcon = GetImageSource(CodeExplorerUI.status_offline);
+
         private static readonly IDictionary<DeclarationType,BitmapImage> Icons = new Dictionary<DeclarationType, BitmapImage>
         {
             { DeclarationType.ClassModule, GetImageSource(CodeExplorerUI.ObjectClass) },
@@ -222,6 +227,22 @@ private DeclarationType DeclarationType
             { DeclarationType.RelatedDocument, GetImageSource(CodeExplorerUI.document_import)}
         };
 
+        private void SetIcon()
+        {
+            if (IsPredeclared)
+            {
+                _icon = PredeclaredIcon;
+                return;
+            }
+
+            if (Icons.ContainsKey(DeclarationType))
+            {
+                _icon = Icons[DeclarationType];
+            }
+
+            _icon = OopsIcon;
+        }
+
         private BitmapImage _icon;
         public override BitmapImage CollapsedIcon => _icon;
         public override BitmapImage ExpandedIcon => _icon;

Rubberduck.Resources/CodeExplorer/CodeExplorerUI.Designer.cs

@@ -412,4 +412,7 @@
   <data name="CodeExplorer_LibraryReferences" xml:space="preserve">
     <value>Library References</value>
   </data>
+  <data name="ObjectClassPredeclared" type="System.Resources.ResXFileRef, System.Windows.Forms">
+    <value>..\Icons\Custom\PNG\ObjectClassPredeclared.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
+  </data>
 </root>