Toggle error icon in create branch form

Author: Hosch250

RetailCoder.VBE/UI/SourceControl/BranchesPresenter.cs

@@ -176,7 +176,7 @@ private void OnCreateViewCancel(object sender, EventArgs e)
 
         private void OnCreateBranchTextChanged(object sender, EventArgs e)
         {
-            _createView.OkButtonEnabled = !string.IsNullOrEmpty(_createView.UserInputText) &&
+            _createView.IsValidBranchName = !string.IsNullOrEmpty(_createView.UserInputText) &&
                                           !_view.Local.Contains(_createView.UserInputText) &&
                                           !_createView.UserInputText.Any(char.IsWhiteSpace);
         }

RetailCoder.VBE/UI/SourceControl/CreateBranchForm.cs

@@ -26,10 +26,14 @@ public string UserInputText
             set { this.UserInputBox.Text = value; }
         }
 
-        public bool OkButtonEnabled
+        public bool IsValidBranchName
         {
             get { return this.OkButton.Enabled; }
-            set { this.OkButton.Enabled = value; }
+            set
+            {
+                this.OkButton.Enabled = value;
+                this.InvalidNameValidationIcon.Visible = !value;
+            }
         }
 
         public event EventHandler<BranchCreateArgs> Confirm;

RetailCoder.VBE/UI/SourceControl/ICreateBranchView.cs

@@ -6,7 +6,7 @@ namespace Rubberduck.UI.SourceControl
     public interface ICreateBranchView
     {
         string UserInputText { get; set; }
-        bool OkButtonEnabled { get; set; }
+        bool IsValidBranchName { get; set; }
 
         event EventHandler<BranchCreateArgs> Confirm;
         event EventHandler<EventArgs> Cancel;

RubberduckTests/SourceControl/BranchesPresenterTests.cs

@@ -250,13 +250,13 @@ public void CreateBranch_AndBranchExists()
 
             _view.SetupProperty(v => v.Local, branches);
             _createView.SetupProperty(c => c.UserInputText, branchName);
-            _createView.SetupProperty(c => c.OkButtonEnabled);
+            _createView.SetupProperty(c => c.IsValidBranchName);
 
             //act
             _createView.Raise(c => c.UserInputTextChanged += null, new EventArgs());
 
             //Assert
-            Assert.IsFalse(_createView.Object.OkButtonEnabled);
+            Assert.IsFalse(_createView.Object.IsValidBranchName);
         }
 
         [TestMethod]
@@ -269,13 +269,13 @@ public void CreateBranch_AndValidBranchName()
 
             _view.SetupProperty(v => v.Local, branches);
             _createView.SetupProperty(c => c.UserInputText, newBranchName);
-            _createView.SetupProperty(c => c.OkButtonEnabled);
+            _createView.SetupProperty(c => c.IsValidBranchName);
 
             //act
             _createView.Raise(c => c.UserInputTextChanged += null, new EventArgs());
 
             //Assert
-            Assert.IsTrue(_createView.Object.OkButtonEnabled);
+            Assert.IsTrue(_createView.Object.IsValidBranchName);
         }
 
         [TestMethod]
@@ -287,13 +287,13 @@ public void CreateBranch_WithNameAsMultipleWords()
 
             _view.SetupProperty(v => v.Local, branches);
             _createView.SetupProperty(c => c.UserInputText, branchName);
-            _createView.SetupProperty(c => c.OkButtonEnabled);
+            _createView.SetupProperty(c => c.IsValidBranchName);
 
             //act
             _createView.Raise(c => c.UserInputTextChanged += null, new EventArgs());
 
             //Assert
-            Assert.IsFalse(_createView.Object.OkButtonEnabled);
+            Assert.IsFalse(_createView.Object.IsValidBranchName);
         }
 
         [TestMethod]