Stop collecting TKIND_UNION (unsupported), initial eval binding support.

Author: comintern

Rubberduck.Parsing/ComReflection/ComMember.cs

@@ -12,6 +12,18 @@
 
 namespace Rubberduck.Parsing.ComReflection
 {
+    internal enum DispId
+    {
+        Collect = -8,           //The method you are calling through Invoke is an accessor function. 
+        Destructor = -7,        //The C++ destructor function for the object. 
+        Construtor = -6,        //The C++ constructor function for the object. 
+        Evaluate = -5,          //This method is implicitly invoked when the ActiveX client encloses the arguments in square brackets.
+        NewEnum = -4,           //It returns an enumerator object that supports IEnumVARIANT.
+        PropertyPut = -3,       //The parameter that receives the value of an assignment in a PROPERTYPUT. 
+        Unknown = -1,           //The value returned by IDispatch::GetIDsOfNames to indicate that a member or parameter name was not found.
+        Value = 0               //The default member for the object.
+    }
+
     [DebuggerDisplay("{MemberDeclaration}")]
     public class ComMember : ComBase
     {
@@ -20,6 +32,8 @@ public class ComMember : ComBase
         public bool ReturnsWithEventsObject { get; private set; }
         public bool IsDefault { get; private set; }
         public bool IsEnumerator { get; private set; }
+        //This member is called on an interface when a bracketed expression is dereferenced.
+        public bool IsEvaluateFunction { get; private set; }
         public ComParameter ReturnType { get; private set; }
         public List<ComParameter> Parameters { get; set; }
 
@@ -30,8 +44,9 @@ public ComMember(ITypeInfo info, FUNCDESC funcDesc) : base(info, funcDesc)
             IsHidden = flags.HasFlag(FUNCFLAGS.FUNCFLAG_FHIDDEN);
             IsRestricted = flags.HasFlag(FUNCFLAGS.FUNCFLAG_FRESTRICTED);
             ReturnsWithEventsObject = flags.HasFlag(FUNCFLAGS.FUNCFLAG_FSOURCE);
-            IsDefault = Index == 0;
-            IsEnumerator = Index == -4;
+            IsDefault = Index == (int)DispId.Value;
+            IsEnumerator = Index == (int)DispId.NewEnum;
+            IsEvaluateFunction = Index == (int)DispId.Evaluate;
             SetDeclarationType(funcDesc, info);
         }
 

Rubberduck.Parsing/ComReflection/ComProject.cs

@@ -120,8 +120,6 @@ private void LoadModules(ITypeLib typeLibrary)
                             if (type != null) KnownTypes.TryAdd(typeAttributes.guid, coclass);
                             break;
                         case TYPEKIND.TKIND_ALIAS:
-                        case TYPEKIND.TKIND_UNION:
-                            
                         //The current handling of this is wrong - these don't have to be classes or interfaces. In the VBE module for example,
                             //"LongPtr" is defined as an alias to "Long" (at least on a 32 bit system) - RD is currently treating is like a class.  
                             //Unclear if these can *also* define alternative names for interfaces as well, but all the ones I've seen have been basically
@@ -141,6 +139,9 @@ private void LoadModules(ITypeLib typeLibrary)
                             _modules.Add(module as ComModule);
                             if (type != null) KnownTypes.TryAdd(typeAttributes.guid, module);
                             break;
+                        case TYPEKIND.TKIND_UNION:
+                            //TKIND_UNION is not a supported member type in VBA.
+                            break;
                         default:
                             throw new NotImplementedException(string.Format("Didn't expect a TYPEATTR with multiple typekind flags set in {0}.", Path));
                     }