Even more catching and logging

Author: MDoerner

Rubberduck.VBEEditor/SafeComWrappers/Abstract/HostApplicationBase.cs

@@ -26,14 +26,21 @@ private static TApplication ApplicationFromComReflection(string applicationName)
             {
                 application = (TApplication) Marshal.GetActiveObject($"{applicationName}.Application");
             }
-            catch (COMException)
+            catch (COMException exception)
             {
-                application = null; // unit tests don't need it anyway.
+                _logger.Error(exception, $"Unexpected COM exception while acquiring the host application object for application {applicationName} via COM reflection.");
+                application = null; // We currently really only use the name anyway.
             }
             catch (InvalidCastException exception)
             {
                 //TODO: Find out why this ever happens.
-                _logger.Error(exception, $"Unable to cast the host Application {applicationName} to its PIA type.");
+                _logger.Error(exception, $"Unable to cast the host application object for application {applicationName} acquired via COM reflection to its PIA type.");
+                application = null; //We currently really only use the name anyway.
+            }
+            catch (Exception exception)
+            {
+                //note: We catch all exceptions because we currently really do not need application object and there can be exceptions for unexpected system setups.
+                _logger.Error(exception, $"Unexpected exception while acquiring the host application object for application {applicationName} from a document module.");
                 application = null; //We currently really only use the name anyway.
             }
             return application;
@@ -44,24 +51,33 @@ private static TApplication ApplicationFromVbe(IVBE vbe, string applicationName)
             TApplication application;
             try
             {
-                var appProperty = ApplicationPropertyFromDocumentModule(vbe);
-                if (appProperty != null)
+                using (var appProperty = ApplicationPropertyFromDocumentModule(vbe))
                 {
-                    application = (TApplication)appProperty.Object;
-                }
-                else
-                {
-                    application = (TApplication)Marshal.GetActiveObject($"{applicationName}.Application");
+                    if (appProperty != null)
+                    {
+                        application = (TApplication) appProperty.Object;
+                    }
+                    else
+                    {
+                        application = ApplicationFromComReflection(applicationName);
+                    }
                 }
 
             }
-            catch (COMException)
+            catch (COMException exception)
             {
-                application = null; // unit tests don't need it anyway.
+                _logger.Error(exception, $"Unexpected COM exception while acquiring the host application object for application {applicationName} from a document module.");
+                application = null; // We currently really only use the name anyway.
             }
             catch (InvalidCastException exception)
             {
-                _logger.Error(exception, $"Unable to cast the host Application {applicationName} to its PIA type.");
+                _logger.Error(exception, $"Unable to cast the host application object for application {applicationName} acquiered from a document module to its PIA type.");
+                application = null; //We currently really only use the name anyway.
+            }
+            catch (Exception exception)
+            {
+                //note: We catch all exceptions because we currently really do not need application object and there can be exceptions for unexpected system setups.
+                _logger.Error(exception, $"Unexpected exception while acquiring the host application object for application {applicationName} from a document module.");
                 application = null; //We currently really only use the name anyway.
             }
             return application;