only look at self assigned variable declarations (fixes #1048)

Andrin Meier · Andrin Meier · commit 7e64a7fbf0ce · 2016-02-09T19:51:48.000+01:00
diff --git a/RetailCoder.VBE/Inspections/SelfAssignedDeclarationInspection.cs b/RetailCoder.VBE/Inspections/SelfAssignedDeclarationInspection.cs
@@ -1,6 +1,7 @@
 ﻿using System.Collections.Generic;
 using System.Linq;
 using Rubberduck.Parsing.VBA;
+using Rubberduck.Parsing.Symbols;
 
 namespace Rubberduck.Inspections
 {
@@ -18,7 +19,7 @@ public SelfAssignedDeclarationInspection(RubberduckParserState state)
         public override IEnumerable<CodeInspectionResultBase> GetInspectionResults()
         {
             return UserDeclarations
-                .Where(declaration => declaration.IsSelfAssigned)
+                .Where(declaration => declaration.IsSelfAssigned && declaration.DeclarationType == DeclarationType.Variable)
                 .Select(issue => new SelfAssignedDeclarationInspectionResult(this, issue));
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`using System.Collections.Generic;`
`2`	`2`	`using System.Linq;`
`3`	`3`	`using Rubberduck.Parsing.VBA;`
	`4`	`+using Rubberduck.Parsing.Symbols;`
`4`	`5`
`5`	`6`	`namespace Rubberduck.Inspections`
`6`	`7`	`{`
`@@ -18,7 +19,7 @@ public SelfAssignedDeclarationInspection(RubberduckParserState state)`
`18`	`19`	`public override IEnumerable<CodeInspectionResultBase> GetInspectionResults()`
`19`	`20`	`{`
`20`	`21`	`return UserDeclarations`
`21`		`- .Where(declaration => declaration.IsSelfAssigned)`
	`22`	`+ .Where(declaration => declaration.IsSelfAssigned && declaration.DeclarationType == DeclarationType.Variable)`
`22`	`23`	`.Select(issue => new SelfAssignedDeclarationInspectionResult(this, issue));`
`23`	`24`	`}`
`24`	`25`	`}`