Skip to content

Commit 7e43b6c

Browse files
committed
Handle network errors on version checking. Closes #2657
1 parent 751671d commit 7e43b6c

File tree

1 file changed

+15
-8
lines changed

1 file changed

+15
-8
lines changed

RetailCoder.VBE/VersionCheck/IVersionCheck.cs

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,22 @@ public VersionCheck()
2626
{
2727
if (_latestVersion != default(Version)) { return _latestVersion; }
2828

29-
using (var client = new HttpClient())
29+
try
3030
{
31-
var url = new Uri("http://rubberduckvba.com/Build/Version/Stable");
32-
var response = await client.GetAsync(url, token);
33-
var content = await response.Content.ReadAsStringAsync();
34-
var doc = new HtmlAgilityPack.HtmlDocument();
35-
doc.LoadHtml(content);
36-
var version = doc.DocumentNode.Descendants("body").Single().InnerText.Trim();
37-
return _latestVersion = new Version(version);
31+
using (var client = new HttpClient())
32+
{
33+
var url = new Uri("http://rubberduckvba.com/Build/Version/Stable");
34+
var response = await client.GetAsync(url, token);
35+
var content = await response.Content.ReadAsStringAsync();
36+
var doc = new HtmlAgilityPack.HtmlDocument();
37+
doc.LoadHtml(content);
38+
var version = doc.DocumentNode.Descendants("body").Single().InnerText.Trim();
39+
return _latestVersion = new Version(version);
40+
}
41+
}
42+
catch
43+
{
44+
return _latestVersion;
3845
}
3946
}
4047

0 commit comments

Comments
 (0)