Merge pull request #3427 from Hosch250/nameLength

Validate identifier length when renaming

Author: retailcoder

RetailCoder.VBE/UI/Refactorings/Rename/RenameViewModel.cs

@@ -72,7 +72,8 @@ public bool IsValidName
                 return !(NewName.Equals(Target.IdentifierName, StringComparison.InvariantCultureIgnoreCase)) &&
                        char.IsLetter(NewName.FirstOrDefault()) &&
                        !tokenValues.Contains(NewName, StringComparer.InvariantCultureIgnoreCase) &&
-                       !NewName.Any(c => !char.IsLetterOrDigit(c) && c != '_');
+                       !NewName.Any(c => !char.IsLetterOrDigit(c) && c != '_') &&
+                       NewName.Length <= (Target.DeclarationType.HasFlag(DeclarationType.Module) ? Declaration.MaxModuleNameLength : Declaration.MaxMemberNameLength);
             }
         }
 

Rubberduck.Parsing/Symbols/Declaration.cs

@@ -19,6 +19,9 @@ namespace Rubberduck.Parsing.Symbols
     [DebuggerDisplay("({DeclarationType}) {Accessibility} {IdentifierName} As {AsTypeName} | {Selection}")]
     public class Declaration : IEquatable<Declaration>
     {
+        public const int MaxModuleNameLength = 31;
+        public const int MaxMemberNameLength = 255;
+
         public Declaration(
             QualifiedMemberName qualifiedName,
             Declaration parentDeclaration,